Commit b4ee33c7 authored by Peter Boström's avatar Peter Boström Committed by Commit Bot

Add titlecase to extension-installed bubble.

Also removes a stale promo string that has been replaced.

Bug: chromium:807886
Change-Id: I63d64ec65573eb2742fcb59cea790a720fae0a41
Reviewed-on: https://chromium-review.googlesource.com/900053Reviewed-by: default avatarBret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534217}
parent 28d782ef
...@@ -536,15 +536,19 @@ Chromium is unable to recover your settings. ...@@ -536,15 +536,19 @@ Chromium is unable to recover your settings.
<if expr="enable_extensions"> <if expr="enable_extensions">
<!-- Extension installed bubble --> <!-- Extension installed bubble -->
<message name="IDS_EXTENSION_INSTALLED_HEADING" desc="First line in the content area of the extension installed bubble. Instructs that the extension was installed."> <if expr="use_titlecase">
<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph> has been added to Chromium. <message name="IDS_EXTENSION_INSTALLED_HEADING" desc="In Title Case: Title of the extension-installed bubble. Instructs that the extension was installed.">
</message> <ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph> Has Been Added to Chromium
</message>
</if>
<if expr="not use_titlecase">
<message name="IDS_EXTENSION_INSTALLED_HEADING" desc="Title of the extension-installed bubble. Instructs that the extension was installed.">
<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph> has been added to Chromium
</message>
</if>
<message name="IDS_EXTENSION_INSTALLED_SYNC_PROMO_LINK_NEW" desc="Text of the link to sign in to Chromium from the extension installed bubble. This will be converted to a link, with additional text around it."> <message name="IDS_EXTENSION_INSTALLED_SYNC_PROMO_LINK_NEW" desc="Text of the link to sign in to Chromium from the extension installed bubble. This will be converted to a link, with additional text around it.">
sign in to Chromium sign in to Chromium
</message> </message>
<message name="IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK" desc="The first part of the sign-in promo paragraph. This part will be converted to a link and will get more text appended to it (see IDS_EXTENSION_INSTALLED_SIGNIN_PROMO). Keep this text short.">
Sign in to Chromium
</message>
<!-- Extension context menu --> <!-- Extension context menu -->
<if expr="not use_titlecase"> <if expr="not use_titlecase">
......
...@@ -4005,9 +4005,6 @@ are declared in build/common.gypi. ...@@ -4005,9 +4005,6 @@ are declared in build/common.gypi.
<message name="IDS_EXTENSION_INSTALLED_SYNC_PROMO_NEW" desc="Text of the sync promo at the bottom of the extension installed bubble, prompting the user to sign in in order to sync extensions."> <message name="IDS_EXTENSION_INSTALLED_SYNC_PROMO_NEW" desc="Text of the sync promo at the bottom of the extension installed bubble, prompting the user to sign in in order to sync extensions.">
To get your extensions on all your computers, <ph name="SIGN_IN_LINK">$1<ex>sign in to Chrome</ex></ph>. To get your extensions on all your computers, <ph name="SIGN_IN_LINK">$1<ex>sign in to Chrome</ex></ph>.
</message> </message>
<message name="IDS_EXTENSION_INSTALLED_SIGNIN_PROMO" desc="The remaining text of the sign-in promo paragraph. Will be appended as a label to the string above. The triple single quotes are needed to preserve the space before the word 'to' (which is handy when the language (Chrome is being translated to) uses space as word separator).">
''' to get this extension, your history, and other Chrome settings on all your devices.'''
</message>
<!-- Begin of Sync Promo strings for Desktop Identity Consistency. --> <!-- Begin of Sync Promo strings for Desktop Identity Consistency. -->
<message name="IDS_EXTENSION_INSTALLED_DICE_PROMO_SIGNIN_MESSAGE" desc="Text of the sync promo displayed at the bottom of the extension installed bubble asking the user to sign in and enable sync."> <message name="IDS_EXTENSION_INSTALLED_DICE_PROMO_SIGNIN_MESSAGE" desc="Text of the sync promo displayed at the bottom of the extension installed bubble asking the user to sign in and enable sync.">
......
...@@ -544,17 +544,21 @@ Google Chrome is unable to recover your settings. ...@@ -544,17 +544,21 @@ Google Chrome is unable to recover your settings.
Add to Chrome Add to Chrome
</message> </message>
<!-- Extension installed bubble -->
<if expr="enable_extensions"> <if expr="enable_extensions">
<message name="IDS_EXTENSION_INSTALLED_HEADING" desc="First line in the content area of the extension installed bubble. Instructs that the extension was installed."> <!-- Extension installed bubble -->
<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph> has been added to Chrome. <if expr="use_titlecase">
</message> <message name="IDS_EXTENSION_INSTALLED_HEADING" desc="In Title Case: Title of the extension-installed bubble. Instructs that the extension was installed.">
<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph> Has Been Added to Chrome
</message>
</if>
<if expr="not use_titlecase">
<message name="IDS_EXTENSION_INSTALLED_HEADING" desc="Title of the extension-installed bubble. Instructs that the extension was installed.">
<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph> has been added to Chrome
</message>
</if>
<message name="IDS_EXTENSION_INSTALLED_SYNC_PROMO_LINK_NEW" desc="Text of the link to sign in to Chrome from the extension installed bubble. This will be converted to a link, with additional text around it."> <message name="IDS_EXTENSION_INSTALLED_SYNC_PROMO_LINK_NEW" desc="Text of the link to sign in to Chrome from the extension installed bubble. This will be converted to a link, with additional text around it.">
sign in to Chrome sign in to Chrome
</message> </message>
<message name="IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK" desc="The first part of the sign-in promo paragraph. This part will be converted to a link and will get more text appended to it (see IDS_EXTENSION_INSTALLED_SIGNIN_PROMO). Keep this text short.">
Sign in to Chrome
</message>
<!-- Extension context menu --> <!-- Extension context menu -->
<if expr="not use_titlecase"> <if expr="not use_titlecase">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment