Position fixed backgrounds in table sections correctly

Bug: 35697 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62 Reviewed-on: https://chromium-review.googlesource.com/594987 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491294}

Position fixed backgrounds in table sections correctly
Bug: 35697 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62 Reviewed-on: https://chromium-review.googlesource.com/594987 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491294}
b4ee3ace · Robert Hogan · Commit Bot · d6866efd · b4ee3ace · b4ee3ace
Commit b4ee3ace authored Aug 02, 2017 by Robert Hogan Committed by Commit Bot Aug 02, 2017
17 changed files
--- a/third_party/WebKit/LayoutTests/fast/table/backgr_fixed-bg-table-expected.txt
+++ b/third_party/WebKit/LayoutTests/fast/table/backgr_fixed-bg-table-expected.txt
+layer at (0,0) size 800x600
+  LayoutView at (0,0) size 800x600
+layer at (0,0) size 800x162
+  LayoutBlockFlow {HTML} at (0,0) size 800x162
+    LayoutBlockFlow {BODY} at (8,16) size 784x138
+      LayoutBlockFlow {P} at (0,0) size 784x20
+        LayoutText {#text} at (0,0) size 508x19
+          text run at (0,0) width 508: "crbug.com/35697: The coloured bands show flow seamlessly in the background."
+      LayoutTable {TABLE} at (0,36) size 228x102
+        LayoutTableSection {THEAD} at (0,0) size 228x102
+          LayoutTableRow {TR} at (0,2) size 228x98
+            LayoutTableCell {TH} at (2,50) size 111x2 [r=0 c=0 rs=1 cs=1]
+            LayoutTableCell {TH} at (115,50) size 111x2 [r=0 c=1 rs=1 cs=1]
--- a/third_party/WebKit/LayoutTests/fast/table/backgr_fixed-bg-table.html
+++ b/third_party/WebKit/LayoutTests/fast/table/backgr_fixed-bg-table.html
+<!DOCTYPE html>
+<style>
+.d {width: 109px}
+.d {height: 96px}
+thead{background:url(resources/rainbowh.gif) fixed;}
+</style>
+<p>crbug.com/35697: The coloured bands show flow seamlessly in the background.</p>
+<table>
+  <thead>
+    <tr class="th-row-1">
+      <th class="d"></th>
+      <th class="d"></th>
+    </tr>
+  </thead>
+</table>
--- a/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_fixed-bg-table-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_fixed-bg-table-expected.png
--- a/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_fixed-bg-table-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_fixed-bg-table-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_fixed-bg-table-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac/fast/table/backgr_fixed-bg-table-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/fast/table/backgr_fixed-bg-table-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/fast/table/backgr_fixed-bg-table-expected.png
--- a/third_party/WebKit/LayoutTests/platform/win/fast/table/backgr_fixed-bg-table-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/win/fast/table/backgr_fixed-bg-table-expected.png
--- a/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/backgr_fixed-bg-table-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/backgr_fixed-bg-table-expected.png
--- a/third_party/WebKit/LayoutTests/platform/win7/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/win7/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
--- a/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
+++ b/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
@@ -518,6 +518,7 @@ void BackgroundImageGeometry::Calculate(const LayoutBoxModelObject* container,
    }
  } else {
    SetHasNonLocalGeometry();
+    offset_in_background_ = LayoutPoint();
    positioning_area = FixedAttachmentPositioningArea(box_, container, flags);
    SetDestRect(positioning_area);
  }