Skip to content

GitLab

T
tangled
Commit b550067b authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot
Browse files
Options

[FragmentItem] Fix hit-testing floats in legacy root 

This patch fixes hit-testing floating objects in a legacy
root.

With |NGPaintFragment|, floats are in children, and that
regular traversal can cover this case.

With |FragmentItem|, floats are either in |NGFragmentItems|
if it has an inline formatting context, or in children
otherwise. This difference requires additional branch to the
legacy fallback when hit-testing floating objects.

Bug: 1096259
Change-Id: I8565eb663781318233c21482270804cf254e0aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249249Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779715}
parent ff62af3f
Hide whitespace changes
Inline Side-by-side
Showing with 74 additions and 1 deletion
third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
View file @ b550067b
......@@ -2365,7 +2365,20 @@ bool NGBoxFragmentPainter::HitTestFloatingChildren(
const auto* child_container =
DynamicTo<NGPhysicalContainerFragment>(&child_fragment);
if (!child_container || !child_container->HasFloatingDescendantsForPaint())
if (!child_container)
continue;
// If this is a legacy root, fallback to legacy. It does not have
// |HasFloatingDescendantsForPaint()| set, but it may have floating
// descendants.
if (child_container->IsLegacyLayoutRoot() &&
RuntimeEnabledFeatures::LayoutNGFragmentItemEnabled()) {
if (child_container->GetMutableLayoutObject()->NodeAtPoint(
*hit_test.result, hit_test.location, child_offset,
hit_test.action))
return true;
continue;
}
if (!child_container->HasFloatingDescendantsForPaint())
continue;
if (child_container->HasOverflowClip()) {
......
third_party/blink/web_tests/external/wpt/css/cssom-view/elementFromPoint-float-in-table.html 0 → 100644
View file @ b550067b
<!DOCTYPE html>
<link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#floats" />
<link rel="help" href="https://drafts.csswg.org/cssom-view/#dom-document-elementfrompoint" />
<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
.outer {
width: 100px;
height: 100px;
background: green;
}
.inner {
float: left;
width: 50px;
height: 50px;
background: blue;
}
</style>
<body>
<div id="log"></div>
<div class="outer" onclick="clicked('outer')">
<div id="float-in-div" class="inner" onclick="clicked('inner')">
</div>
</div>
<table>
<tr>
<td>
<div class="outer" onclick="clicked('outer')">
<div id='float-in-table' class="inner" onclick="clicked('inner')">
</div>
</div>
</td>
</tr>
</table>
<pre id="output"></pre>
<script>
function clicked(p) {
output.textContent += 'clicked ' + p + '\n';
}
function testElementFromPoint(element) {
let bounds = element.getBoundingClientRect();
let result = document.elementFromPoint(bounds.x + 1, bounds.y + 1);
assert_equals(result, element);
}
let targets = [
'float-in-div',
'float-in-table',
];
for (let target of targets) {
let element = document.getElementById(target);
test(() => { testElementFromPoint(element); }, target);
}
</script>
</body>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment