Commit b592282e authored by Mike Wittman's avatar Mike Wittman Committed by Commit Bot

[Sampling profiler] Remove heap profiler OnSampleCompleted interface

This interface is unused within CallStackProfileBuilder. The equivalent
functionality will be supported eventually within the class but will
occur via the metadata mechanism.

Bug: 851163
Change-Id: I3bd8430de70c973c3e4a293118403312b977f8d1
Reviewed-on: https://chromium-review.googlesource.com/c/1351533Reviewed-by: default avatarXi Cheng <chengx@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611935}
parent c3828a4f
...@@ -62,14 +62,6 @@ CallStackProfileBuilder::~CallStackProfileBuilder() = default; ...@@ -62,14 +62,6 @@ CallStackProfileBuilder::~CallStackProfileBuilder() = default;
// static // static
void CallStackProfileBuilder::OnSampleCompleted( void CallStackProfileBuilder::OnSampleCompleted(
std::vector<base::StackSamplingProfiler::Frame> frames) { std::vector<base::StackSamplingProfiler::Frame> frames) {
OnSampleCompleted(std::move(frames), 1);
}
// TODO(wittman): record |count| as per-Stacksample metadata in the new proto
// format.
void CallStackProfileBuilder::OnSampleCompleted(
std::vector<base::StackSamplingProfiler::Frame> frames,
size_t /*count*/) {
// Write CallStackProfile::Stack protobuf message. // Write CallStackProfile::Stack protobuf message.
CallStackProfile::Stack stack; CallStackProfile::Stack stack;
......
...@@ -45,11 +45,6 @@ class CallStackProfileBuilder ...@@ -45,11 +45,6 @@ class CallStackProfileBuilder
void OnProfileCompleted(base::TimeDelta profile_duration, void OnProfileCompleted(base::TimeDelta profile_duration,
base::TimeDelta sampling_period) override; base::TimeDelta sampling_period) override;
// The function is used by sampling heap profiler. Its samples already come
// with different counts.
void OnSampleCompleted(std::vector<base::StackSamplingProfiler::Frame> frames,
size_t count);
// Sets the callback to use for reporting browser process profiles. This // Sets the callback to use for reporting browser process profiles. This
// indirection is required to avoid a dependency on unnecessary metrics code // indirection is required to avoid a dependency on unnecessary metrics code
// in child processes. // in child processes.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment