Commit b5a10d7e authored by Scott Little's avatar Scott Little Committed by Commit Bot

Remove redundant call of language::GetOverrideLanguageModel().

The result of the call is unused, and it's called again for the switch
statement directly below it, so this CL removes the unused call.

Change-Id: If5d86d4c30286057442dd8f9d06ef0a0b314487b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210926
Auto-Submit: Scott Little <sclittle@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: default avatarAlexandre Frechette <frechette@chromium.org>
Reviewed-by: default avataranthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771608}
parent 9d15054f
...@@ -27,48 +27,44 @@ namespace { ...@@ -27,48 +27,44 @@ namespace {
void PrepareLanguageModels(Profile* const profile, void PrepareLanguageModels(Profile* const profile,
language::LanguageModelManager* const manager) { language::LanguageModelManager* const manager) {
language::GetOverrideLanguageModel(); // Create and set the primary Language Model to use based on the state of
// experiments.
// Create and set the primary Language Model to use based on the state of switch (language::GetOverrideLanguageModel()) {
// experiments. case language::OverrideLanguageModel::FLUENT:
switch (language::GetOverrideLanguageModel()) { manager->AddModel(
case language::OverrideLanguageModel::FLUENT: language::LanguageModelManager::ModelType::FLUENT,
manager->AddModel( std::make_unique<language::FluentLanguageModel>(
language::LanguageModelManager::ModelType::FLUENT, profile->GetPrefs(), language::prefs::kAcceptLanguages));
std::make_unique<language::FluentLanguageModel>( manager->SetPrimaryModel(
profile->GetPrefs(), language::prefs::kAcceptLanguages)); language::LanguageModelManager::ModelType::FLUENT);
manager->SetPrimaryModel( break;
language::LanguageModelManager::ModelType::FLUENT); case language::OverrideLanguageModel::HEURISTIC:
break; manager->AddModel(
case language::OverrideLanguageModel::HEURISTIC: language::LanguageModelManager::ModelType::HEURISTIC,
manager->AddModel( std::make_unique<language::HeuristicLanguageModel>(
language::LanguageModelManager::ModelType::HEURISTIC, profile->GetPrefs(), g_browser_process->GetApplicationLocale(),
std::make_unique<language::HeuristicLanguageModel>( language::prefs::kAcceptLanguages,
profile->GetPrefs(), language::prefs::kUserLanguageProfile));
g_browser_process->GetApplicationLocale(), manager->SetPrimaryModel(
language::prefs::kAcceptLanguages, language::LanguageModelManager::ModelType::HEURISTIC);
language::prefs::kUserLanguageProfile)); break;
manager->SetPrimaryModel( case language::OverrideLanguageModel::GEO:
language::LanguageModelManager::ModelType::HEURISTIC); manager->AddModel(language::LanguageModelManager::ModelType::GEO,
break; std::make_unique<language::GeoLanguageModel>(
case language::OverrideLanguageModel::GEO: language::GeoLanguageProvider::GetInstance()));
manager->AddModel(language::LanguageModelManager::ModelType::GEO, manager->SetPrimaryModel(language::LanguageModelManager::ModelType::GEO);
std::make_unique<language::GeoLanguageModel>( break;
language::GeoLanguageProvider::GetInstance())); case language::OverrideLanguageModel::DEFAULT:
manager->SetPrimaryModel( default:
language::LanguageModelManager::ModelType::GEO); manager->AddModel(
break; language::LanguageModelManager::ModelType::BASELINE,
case language::OverrideLanguageModel::DEFAULT: std::make_unique<language::BaselineLanguageModel>(
default: profile->GetPrefs(), g_browser_process->GetApplicationLocale(),
manager->AddModel(language::LanguageModelManager::ModelType::BASELINE, language::prefs::kAcceptLanguages));
std::make_unique<language::BaselineLanguageModel>( manager->SetPrimaryModel(
profile->GetPrefs(), language::LanguageModelManager::ModelType::BASELINE);
g_browser_process->GetApplicationLocale(), break;
language::prefs::kAcceptLanguages)); }
manager->SetPrimaryModel(
language::LanguageModelManager::ModelType::BASELINE);
break;
}
} }
} // namespace } // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment