Commit b5a10d7e authored by Scott Little's avatar Scott Little Committed by Commit Bot

Remove redundant call of language::GetOverrideLanguageModel().

The result of the call is unused, and it's called again for the switch
statement directly below it, so this CL removes the unused call.

Change-Id: If5d86d4c30286057442dd8f9d06ef0a0b314487b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210926
Auto-Submit: Scott Little <sclittle@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: default avatarAlexandre Frechette <frechette@chromium.org>
Reviewed-by: default avataranthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771608}
parent 9d15054f
...@@ -27,8 +27,6 @@ namespace { ...@@ -27,8 +27,6 @@ namespace {
void PrepareLanguageModels(Profile* const profile, void PrepareLanguageModels(Profile* const profile,
language::LanguageModelManager* const manager) { language::LanguageModelManager* const manager) {
language::GetOverrideLanguageModel();
// Create and set the primary Language Model to use based on the state of // Create and set the primary Language Model to use based on the state of
// experiments. // experiments.
switch (language::GetOverrideLanguageModel()) { switch (language::GetOverrideLanguageModel()) {
...@@ -44,8 +42,7 @@ void PrepareLanguageModels(Profile* const profile, ...@@ -44,8 +42,7 @@ void PrepareLanguageModels(Profile* const profile,
manager->AddModel( manager->AddModel(
language::LanguageModelManager::ModelType::HEURISTIC, language::LanguageModelManager::ModelType::HEURISTIC,
std::make_unique<language::HeuristicLanguageModel>( std::make_unique<language::HeuristicLanguageModel>(
profile->GetPrefs(), profile->GetPrefs(), g_browser_process->GetApplicationLocale(),
g_browser_process->GetApplicationLocale(),
language::prefs::kAcceptLanguages, language::prefs::kAcceptLanguages,
language::prefs::kUserLanguageProfile)); language::prefs::kUserLanguageProfile));
manager->SetPrimaryModel( manager->SetPrimaryModel(
...@@ -55,15 +52,14 @@ void PrepareLanguageModels(Profile* const profile, ...@@ -55,15 +52,14 @@ void PrepareLanguageModels(Profile* const profile,
manager->AddModel(language::LanguageModelManager::ModelType::GEO, manager->AddModel(language::LanguageModelManager::ModelType::GEO,
std::make_unique<language::GeoLanguageModel>( std::make_unique<language::GeoLanguageModel>(
language::GeoLanguageProvider::GetInstance())); language::GeoLanguageProvider::GetInstance()));
manager->SetPrimaryModel( manager->SetPrimaryModel(language::LanguageModelManager::ModelType::GEO);
language::LanguageModelManager::ModelType::GEO);
break; break;
case language::OverrideLanguageModel::DEFAULT: case language::OverrideLanguageModel::DEFAULT:
default: default:
manager->AddModel(language::LanguageModelManager::ModelType::BASELINE, manager->AddModel(
language::LanguageModelManager::ModelType::BASELINE,
std::make_unique<language::BaselineLanguageModel>( std::make_unique<language::BaselineLanguageModel>(
profile->GetPrefs(), profile->GetPrefs(), g_browser_process->GetApplicationLocale(),
g_browser_process->GetApplicationLocale(),
language::prefs::kAcceptLanguages)); language::prefs::kAcceptLanguages));
manager->SetPrimaryModel( manager->SetPrimaryModel(
language::LanguageModelManager::ModelType::BASELINE); language::LanguageModelManager::ModelType::BASELINE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment