Commit b5acf97f authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Fix Telemetry tombstones/logcat stack

Fixes Telemetry's tombstone and logcat stack symbolizing not working on
the bots due to missing data dependencies. Instead of including the
files in the Telemetry group, they have now been moved to
//build/android:stack_tools.

Bug: 1041902
Change-Id: I14d614199a7e54bc4dd03a6a2b7379cf229fb8d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006390
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732951}
parent 3067e4e5
...@@ -122,3 +122,15 @@ python_library("bundle_wrapper_script_py") { ...@@ -122,3 +122,15 @@ python_library("bundle_wrapper_script_py") {
"//third_party/android_build_tools/bundletool/bundletool-all-0.11.0.jar", "//third_party/android_build_tools/bundletool/bundletool-all-0.11.0.jar",
] ]
} }
# Tools necessary for symbolizing tombstones or stack traces that are output to
# logcat.
group("stack_tools") {
data = [
"tombstones.py",
"pylib/symbols/",
"stacktrace/",
]
data_deps = [ "//third_party/android_platform/development/scripts:stack_py" ]
}
...@@ -113,9 +113,6 @@ group("telemetry_chrome_test_without_chrome") { ...@@ -113,9 +113,6 @@ group("telemetry_chrome_test_without_chrome") {
} }
if (is_android) { if (is_android) {
data += [ data += [
"//build/android/stacktrace/",
"//build/android/tombstones.py",
# TODO(httpss://crbug.com/833808): Remove this once bots always set # TODO(httpss://crbug.com/833808): Remove this once bots always set
# CHROMIUM_OUTPUT_DIR correctly. Currently, this is necessary in order # CHROMIUM_OUTPUT_DIR correctly. Currently, this is necessary in order
# for //build/android/pylib/constants/__init__.py to detect the output # for //build/android/pylib/constants/__init__.py to detect the output
...@@ -124,6 +121,7 @@ group("telemetry_chrome_test_without_chrome") { ...@@ -124,6 +121,7 @@ group("telemetry_chrome_test_without_chrome") {
] ]
data_deps += [ data_deps += [
"//build/android:devil_chromium_py", "//build/android:devil_chromium_py",
"//build/android:stack_tools",
"//chrome/android/webapk/shell_apk:maps_go_webapk", "//chrome/android/webapk/shell_apk:maps_go_webapk",
"//third_party/breakpad:dump_syms", "//third_party/breakpad:dump_syms",
"//third_party/breakpad:minidump_dump", "//third_party/breakpad:minidump_dump",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment