Commit b5affd88 authored by vadimt's avatar vadimt Committed by Commit bot

Naming more views and windows to simplify debugging.

Bug=712331

Review-Url: https://codereview.chromium.org/2865553002
Cr-Commit-Position: refs/heads/master@{#469535}
parent 2008e5c9
......@@ -43,7 +43,7 @@ void RecordRequestResult(SearchAnswerRequestResult request_result) {
class SearchAnswerWebView : public views::WebView {
public:
SearchAnswerWebView(content::BrowserContext* browser_context)
explicit SearchAnswerWebView(content::BrowserContext* browser_context)
: WebView(browser_context) {}
// views::WebView overrides:
......@@ -62,6 +62,8 @@ class SearchAnswerWebView : public views::WebView {
}
}
const char* GetClassName() const override { return "SearchAnswerWebView"; }
private:
// Time when the answer became visible to the user.
base::TimeTicks shown_time_;
......
......@@ -376,6 +376,7 @@ void AppListView::InitChildWidgets() {
search_box_widget_params.parent = GetWidget()->GetNativeView();
search_box_widget_params.opacity =
views::Widget::InitParams::TRANSLUCENT_WINDOW;
search_box_widget_params.name = "SearchBoxView";
// Create a widget for the SearchBoxView to live in. This allows the
// SearchBoxView to be on top of the custom launcher page's WebContents
......@@ -403,7 +404,6 @@ void AppListView::InitChildWidgets() {
void AppListView::InitializeFullscreen(gfx::NativeView parent,
int initial_apps_page) {
views::Widget* widget = new views::Widget;
views::Widget::InitParams app_list_overlay_view_params(
views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
......
......@@ -49,6 +49,10 @@ class SearchAnswerContainerView : public views::View {
search_results_page_view_->Layout();
}
const char* GetClassName() const override {
return "SearchAnswerContainerView";
}
private:
views::View* const search_results_page_view_;
......
......@@ -105,6 +105,8 @@ class SearchBoxImageButton : public views::ImageButton {
canvas->FillRect(gfx::Rect(size()), kSelectedColor);
}
const char* GetClassName() const override { return "SearchBoxImageButton"; }
bool selected_;
DISALLOW_COPY_AND_ASSIGN(SearchBoxImageButton);
......@@ -301,6 +303,10 @@ void SearchBoxView::OnEnabledChanged() {
speech_button_->SetEnabled(enabled());
}
const char* SearchBoxView::GetClassName() const {
return "SearchBoxView";
}
void SearchBoxView::UpdateModel() {
// Temporarily remove from observer to ignore notifications caused by us.
model_->search_box()->RemoveObserver(this);
......
......@@ -82,6 +82,7 @@ class APP_LIST_EXPORT SearchBoxView : public views::View,
gfx::Size GetPreferredSize() const override;
bool OnMouseWheel(const ui::MouseWheelEvent& event) override;
void OnEnabledChanged() override;
const char* GetClassName() const override;
private:
// Updates model text and selection model with current Textfield info.
......
......@@ -65,6 +65,10 @@ bool SearchResultContainerView::UpdateScheduled() {
return update_factory_.HasWeakPtrs();
}
const char* SearchResultContainerView::GetClassName() const {
return "SearchResultContainerView";
}
void SearchResultContainerView::ListItemsAdded(size_t start, size_t count) {
ScheduleUpdate();
}
......
......@@ -67,6 +67,9 @@ class APP_LIST_EXPORT SearchResultContainerView : public views::View,
// Returns whether an update is currently scheduled for this container.
bool UpdateScheduled();
// Overridden from views::View:
const char* GetClassName() const override;
// Overridden from ui::ListModelObserver:
void ListItemsAdded(size_t start, size_t count) override;
void ListItemsRemoved(size_t start, size_t count) override;
......
......@@ -104,6 +104,10 @@ void TileItemView::Layout() {
title_->SetBoundsRect(rect);
}
const char* TileItemView::GetClassName() const {
return "TileItemView";
}
void TileItemView::ImageShadowAnimationProgressed(
ImageShadowAnimator* animator) {
icon_->SetImage(animator->shadow_image());
......
......@@ -53,6 +53,7 @@ class APP_LIST_EXPORT TileItemView : public views::CustomButton,
// Overridden from views::View:
void Layout() override;
const char* GetClassName() const override;
// Overridden from ImageShadowAnimator::Delegate:
void ImageShadowAnimationProgressed(ImageShadowAnimator* animator) override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment