Headless: Wire up a basic NetLog if we're not logging to disk

DevTools relies on a NetLogObserver (which needs a NetLog) to return the
raw response headers, e.g. Set-Cookie headers.

Bug: 692090
Change-Id: I9faae71198b7c45d1dc05175b606452012d7ec83
Reviewed-on: https://chromium-review.googlesource.com/565139
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485265}

headless/lib/browser/headless_browser_main_parts.cc

@@ -27,6 +27,8 @@ void HeadlessBrowserMainParts::PreMainMessageLoopRun() {
     base::FilePath log_path =
         command_line->GetSwitchValuePath(switches::kLogNetLog);
     net_log_.reset(new HeadlessNetLog(log_path));
+  } else {
+    net_log_.reset(new net::NetLog());
   }
 
   if (browser_->options()->DevtoolsServerEnabled()) {

headless/lib/browser/headless_browser_main_parts.h

@@ -11,9 +11,12 @@
 #include "content/public/browser/browser_main_parts.h"
 #include "headless/public/headless_browser.h"
 
+namespace net {
+class NetLog;
+}  // namespace net
+
 namespace headless {
 
-class HeadlessNetLog;
 class HeadlessBrowserImpl;
 
 class HeadlessBrowserMainParts : public content::BrowserMainParts {
@@ -28,13 +31,13 @@ class HeadlessBrowserMainParts : public content::BrowserMainParts {
   void PreMainMessageLoopStart() override;
 #endif
 
-  HeadlessNetLog* net_log() const { return net_log_.get(); }
+  net::NetLog* net_log() const { return net_log_.get(); }
 
  private:
   HeadlessBrowserImpl* browser_;  // Not owned.
 
   bool devtools_http_handler_started_;
-  std::unique_ptr<HeadlessNetLog> net_log_;
+  std::unique_ptr<net::NetLog> net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(HeadlessBrowserMainParts);
 };

headless/lib/browser/headless_content_browser_client.cc

@@ -239,4 +239,8 @@ void HeadlessContentBrowserClient::ResourceDispatcherHostCreated() {
       resource_dispatcher_host_delegate_.get());
 }
 
+net::NetLog* HeadlessContentBrowserClient::GetNetLog() {
+  return browser_->browser_main_parts()->net_log();
+}
+
 }  // namespace headless

headless/lib/browser/headless_content_browser_client.h

@@ -52,6 +52,8 @@ class HeadlessContentBrowserClient : public content::ContentBrowserClient {
 
   void ResourceDispatcherHostCreated() override;
 
+  net::NetLog* GetNetLog() override;
+
  private:
   std::unique_ptr<base::Value> GetBrowserServiceManifestOverlay();
   std::unique_ptr<base::Value> GetRendererServiceManifestOverlay();

headless/lib/headless_devtools_client_browsertest.cc

@@ -1438,4 +1438,31 @@ class FailedUrlRequestTest : public HeadlessAsyncDevTooledBrowserTest,
 
 HEADLESS_ASYNC_DEVTOOLED_TEST_F(FailedUrlRequestTest);
 
+class DevToolsSetCookieTest : public HeadlessAsyncDevTooledBrowserTest,
+                              public network::Observer {
+ public:
+  void RunDevTooledTest() override {
+    EXPECT_TRUE(embedded_test_server()->Start());
+    devtools_client_->GetNetwork()->AddObserver(this);
+
+    base::RunLoop run_loop;
+    devtools_client_->GetNetwork()->Enable(run_loop.QuitClosure());
+    base::MessageLoop::ScopedNestableTaskAllower nest_loop(
+        base::MessageLoop::current());
+    run_loop.Run();
+
+    devtools_client_->GetPage()->Navigate(
+        embedded_test_server()->GetURL("/set-cookie?cookie1").spec());
+  }
+
+  void OnResponseReceived(
+      const network::ResponseReceivedParams& params) override {
+    EXPECT_NE(std::string::npos, params.GetResponse()->GetHeadersText().find(
+                                     "Set-Cookie: cookie1"));
+    FinishAsynchronousTest();
+  }
+};
+
+HEADLESS_ASYNC_DEVTOOLED_TEST_F(DevToolsSetCookieTest);
+
 }  // namespace headless