Specify HeapMojoWrapperMode::kForceWithoutContextObserver to SpeechSynthesis
We are going to deprecate kWithoutContextObserver. But SpeechSynthesis had a problem with kWithContextObserver mode. To avoid this problem, we temporally need to specify kForceWithoutContextObserver. When the ExecutionContext was destroyed, HeapMojo wrappers will automatically reset the mojom_synthesis_ mojo::Remote object. After that, if the `blink::SpeechSynthesis::cancel` is called, Null-dereference READ will be happen because it's already reset. To avoid this problem, HeapMojoWrapperMode::kForceWithoutContextObserver have to be specified. if this was specified, HeapMojoRemote doesn't reset mojo::Remote object when the ExecutionContext was destroyed. see also: https://chromium-review.googlesource.com/c/chromium/src/+/2123493 Bug: 1049056, 1058076 Change-Id: I84484ce85ddfc95705acbc7a9e0739a39b2a55ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269597 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#782845}
Showing
Please register or sign in to comment