[ MimeHandlerView ] Change UMA count for MHVC

The main driver of adding UMA for MHVC was to detect postMessage use case
which is limited to MHVCBase created for an <embed>/<object>. This would
exclude the case where a MimeHandlerViewFrameContainer is created in
response to a browser to renderer IPC; which has an <iframe> as its
FrameOwner.

TBR=wjmaclean@chromium.org

Bug: 659750
Change-Id: I8c6e58196ecd72e530fdeafb8031bf2f0c514ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566762Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650577}

extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

@@ -29,6 +29,8 @@ MimeHandlerViewContainer::MimeHandlerViewContainer(
     : GuestViewContainer(render_frame),
       MimeHandlerViewContainerBase(render_frame, info, mime_type, original_url),
       guest_proxy_routing_id_(-1) {
+  RecordInteraction(
+      MimeHandlerViewUMATypes::Type::kDidCreateMimeHandlerViewContainerBase);
   is_embedded_ = !render_frame->GetWebFrame()->GetDocument().IsPluginDocument();
 }
 

extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_base.cc

@@ -200,7 +200,6 @@ MimeHandlerViewContainerBase::MimeHandlerViewContainerBase(
   DCHECK(!mime_type_.empty());
   g_mime_handler_view_container_base_map.Get()[embedder_render_frame].insert(
       this);
-  RecordInteraction(UMAType::kDidCreateMimeHandlerViewContainerBase);
 }
 
 MimeHandlerViewContainerBase::~MimeHandlerViewContainerBase() {

extensions/renderer/guest_view/mime_handler_view/mime_handler_view_frame_container.cc

@@ -84,6 +84,11 @@ void MimeHandlerViewFrameContainer::CreateWithFrame(
     const GURL& resource_url,
     const std::string& mime_type,
     const std::string& view_id) {
+  // TODO(ekaramad): Eventually MHVFC should not request the resource which
+  // means this mode of MHVFC is no longer necessary. After intercepting the
+  // response we should just proceed with creating the MimeHandlerViewGuest
+  // and attaching to the inserted <iframe> on the browser side. The current
+  // renderer state for it seems unnecessary.
   new MimeHandlerViewFrameContainer(web_frame, resource_url, mime_type,
                                     view_id);
 }
@@ -102,6 +107,8 @@ MimeHandlerViewFrameContainer::MimeHandlerViewFrameContainer(
       element_instance_id_(content::RenderThread::Get()->GenerateRoutingID()),
       render_frame_lifetime_observer_(
           new RenderFrameLifetimeObserver(this, GetEmbedderRenderFrame())) {
+  RecordInteraction(
+      MimeHandlerViewUMATypes::Type::kDidCreateMimeHandlerViewContainerBase);
   is_embedded_ = true;
   SendResourceRequest();
 }