Commit b5bc07a0 authored by dpapad's avatar dpapad Committed by Commit Bot

OS Settings: Fix os_about_page:closure_compile target.

The target was failing, because it was pointing to a wrong dependency.
Moreover, it was not properly included in its parent directory's
:closure_compile target, causing it to execute only if one built all
targets, and not as part of the
chrome/browser/resources/settings/chromeos:closure_compile target.

Fixed: 1130048
Change-Id: I21c06f206b24fe524757a3b4ff571835fa9d010f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424027Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809382}
parent 969e33b6
...@@ -208,6 +208,7 @@ group("closure_compile") { ...@@ -208,6 +208,7 @@ group("closure_compile") {
"multidevice_page:closure_compile", "multidevice_page:closure_compile",
"nearby_share_page:closure_compile", "nearby_share_page:closure_compile",
"os_a11y_page:closure_compile", "os_a11y_page:closure_compile",
"os_about_page:closure_compile",
"os_apps_page:closure_compile", "os_apps_page:closure_compile",
"os_files_page:closure_compile", "os_files_page:closure_compile",
"os_languages_page:closure_compile", "os_languages_page:closure_compile",
......
...@@ -21,9 +21,9 @@ js_library("os_about_page") { ...@@ -21,9 +21,9 @@ js_library("os_about_page") {
"../..:lifetime_browser_proxy", "../..:lifetime_browser_proxy",
"../..:router", "../..:router",
"../../about_page:about_page_browser_proxy", "../../about_page:about_page_browser_proxy",
"../../settings_page:main_page_behavior",
"../../settings_page:settings_animated_pages", "../../settings_page:settings_animated_pages",
"../localized_link:localized_link", "../localized_link:localized_link",
"../os_settings_page:main_page_behavior",
"//ui/webui/resources/js:assert", "//ui/webui/resources/js:assert",
"//ui/webui/resources/js:i18n_behavior", "//ui/webui/resources/js:i18n_behavior",
"//ui/webui/resources/js:parse_html_subset", "//ui/webui/resources/js:parse_html_subset",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment