Commit b5e746c6 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Fixed typo in kDownloadManagerStateSuceeded enum value.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2a64eb73c970f14ef344d7bc20ab4258351efe6b
Reviewed-on: https://chromium-review.googlesource.com/944513
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540373}
parent 626002f2
...@@ -13,7 +13,7 @@ typedef NS_ENUM(NSInteger, DownloadManagerState) { ...@@ -13,7 +13,7 @@ typedef NS_ENUM(NSInteger, DownloadManagerState) {
// Download is actively progressing. // Download is actively progressing.
kDownloadManagerStateInProgress, kDownloadManagerStateInProgress,
// Download is completely finished without errors. // Download is completely finished without errors.
kDownloadManagerStateSuceeded, kDownloadManagerStateSucceeded,
// Download has failed with an error. // Download has failed with an error.
kDownloadManagerStateFailed, kDownloadManagerStateFailed,
}; };
......
...@@ -105,7 +105,7 @@ DownloadManagerState DownloadManagerMediator::GetDownloadManagerState() { ...@@ -105,7 +105,7 @@ DownloadManagerState DownloadManagerMediator::GetDownloadManagerState() {
return kDownloadManagerStateInProgress; return kDownloadManagerStateInProgress;
case web::DownloadTask::State::kComplete: case web::DownloadTask::State::kComplete:
return task_->GetErrorCode() ? kDownloadManagerStateFailed return task_->GetErrorCode() ? kDownloadManagerStateFailed
: kDownloadManagerStateSuceeded; : kDownloadManagerStateSucceeded;
case web::DownloadTask::State::kCancelled: case web::DownloadTask::State::kCancelled:
// Download Manager should dismiss the UI after download cancellation. // Download Manager should dismiss the UI after download cancellation.
return kDownloadManagerStateNotStarted; return kDownloadManagerStateNotStarted;
......
...@@ -104,7 +104,7 @@ TEST_F(DownloadManagerMediatorTest, ConsumerInstantUpdate) { ...@@ -104,7 +104,7 @@ TEST_F(DownloadManagerMediatorTest, ConsumerInstantUpdate) {
mediator_.SetDownloadTask(task()); mediator_.SetDownloadTask(task());
mediator_.SetConsumer(consumer_); mediator_.SetConsumer(consumer_);
EXPECT_EQ(kDownloadManagerStateSuceeded, consumer_.state); EXPECT_EQ(kDownloadManagerStateSucceeded, consumer_.state);
EXPECT_NSEQ(kTestSuggestedFileName, consumer_.fileName); EXPECT_NSEQ(kTestSuggestedFileName, consumer_.fileName);
EXPECT_EQ(kTestTotalBytes, consumer_.countOfBytesExpectedToReceive); EXPECT_EQ(kTestTotalBytes, consumer_.countOfBytesExpectedToReceive);
EXPECT_EQ(kTestReceivedBytes, consumer_.countOfBytesReceived); EXPECT_EQ(kTestReceivedBytes, consumer_.countOfBytesReceived);
...@@ -125,14 +125,14 @@ TEST_F(DownloadManagerMediatorTest, ConsumerFailedStateUpdate) { ...@@ -125,14 +125,14 @@ TEST_F(DownloadManagerMediatorTest, ConsumerFailedStateUpdate) {
mediator_.SetDownloadTask(nullptr); mediator_.SetDownloadTask(nullptr);
} }
// Tests that consumer changes the state to kDownloadManagerStateSuceeded if // Tests that consumer changes the state to kDownloadManagerStateSucceeded if
// task competed without an error. // task competed without an error.
TEST_F(DownloadManagerMediatorTest, ConsumerSuceededStateUpdate) { TEST_F(DownloadManagerMediatorTest, ConsumerSuceededStateUpdate) {
mediator_.SetDownloadTask(task()); mediator_.SetDownloadTask(task());
mediator_.SetConsumer(consumer_); mediator_.SetConsumer(consumer_);
task()->SetDone(true); task()->SetDone(true);
EXPECT_EQ(kDownloadManagerStateSuceeded, consumer_.state); EXPECT_EQ(kDownloadManagerStateSucceeded, consumer_.state);
mediator_.SetDownloadTask(nullptr); mediator_.SetDownloadTask(nullptr);
} }
......
...@@ -386,7 +386,7 @@ NSString* GetSizeString(long long size_in_bytes) { ...@@ -386,7 +386,7 @@ NSString* GetSizeString(long long size_in_bytes) {
NOTREACHED(); NOTREACHED();
break; break;
} }
case kDownloadManagerStateSuceeded: { case kDownloadManagerStateSucceeded: {
SEL selector = @selector SEL selector = @selector
(downloadManagerViewController:presentOpenInMenuWithLayoutGuide:); (downloadManagerViewController:presentOpenInMenuWithLayoutGuide:);
if ([_delegate respondsToSelector:selector]) { if ([_delegate respondsToSelector:selector]) {
...@@ -443,7 +443,7 @@ NSString* GetSizeString(long long size_in_bytes) { ...@@ -443,7 +443,7 @@ NSString* GetSizeString(long long size_in_bytes) {
case kDownloadManagerStateInProgress: case kDownloadManagerStateInProgress:
imageName = kDownloadManagerInProgressImage; imageName = kDownloadManagerInProgressImage;
break; break;
case kDownloadManagerStateSuceeded: case kDownloadManagerStateSucceeded:
imageName = kDownloadManagerSucceededImage; imageName = kDownloadManagerSucceededImage;
break; break;
case kDownloadManagerStateFailed: case kDownloadManagerStateFailed:
...@@ -480,7 +480,7 @@ NSString* GetSizeString(long long size_in_bytes) { ...@@ -480,7 +480,7 @@ NSString* GetSizeString(long long size_in_bytes) {
} }
break; break;
} }
case kDownloadManagerStateSuceeded: case kDownloadManagerStateSucceeded:
statusText = _fileName; statusText = _fileName;
break; break;
case kDownloadManagerStateFailed: case kDownloadManagerStateFailed:
...@@ -502,7 +502,7 @@ NSString* GetSizeString(long long size_in_bytes) { ...@@ -502,7 +502,7 @@ NSString* GetSizeString(long long size_in_bytes) {
break; break;
case kDownloadManagerStateInProgress: case kDownloadManagerStateInProgress:
break; break;
case kDownloadManagerStateSuceeded: case kDownloadManagerStateSucceeded:
title = l10n_util::GetNSString(IDS_IOS_OPEN_IN); title = l10n_util::GetNSString(IDS_IOS_OPEN_IN);
break; break;
case kDownloadManagerStateFailed: case kDownloadManagerStateFailed:
......
...@@ -79,9 +79,9 @@ TEST_F(DownloadManagerViewControllerTest, ...@@ -79,9 +79,9 @@ TEST_F(DownloadManagerViewControllerTest,
view_controller_.statusIcon.image); view_controller_.statusIcon.image);
} }
// Tests label and button titles with kDownloadManagerStateSuceeded state. // Tests label and button titles with kDownloadManagerStateSucceeded state.
TEST_F(DownloadManagerViewControllerTest, SuceededWithWithLongFileName) { TEST_F(DownloadManagerViewControllerTest, SuceededWithWithLongFileName) {
view_controller_.state = kDownloadManagerStateSuceeded; view_controller_.state = kDownloadManagerStateSucceeded;
view_controller_.fileName = @"file.txt"; view_controller_.fileName = @"file.txt";
view_controller_.countOfBytesReceived = 1024; view_controller_.countOfBytesReceived = 1024;
...@@ -143,7 +143,7 @@ TEST_F(DownloadManagerViewControllerTest, OpenIn) { ...@@ -143,7 +143,7 @@ TEST_F(DownloadManagerViewControllerTest, OpenIn) {
OCMExpect([delegate downloadManagerViewController:view_controller_ OCMExpect([delegate downloadManagerViewController:view_controller_
presentOpenInMenuWithLayoutGuide:[OCMArg any]]); presentOpenInMenuWithLayoutGuide:[OCMArg any]]);
view_controller_.state = kDownloadManagerStateSuceeded; view_controller_.state = kDownloadManagerStateSucceeded;
view_controller_.delegate = delegate; view_controller_.delegate = delegate;
[view_controller_.actionButton [view_controller_.actionButton
sendActionsForControlEvents:UIControlEventTouchUpInside]; sendActionsForControlEvents:UIControlEventTouchUpInside];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment