Commit b5eb6934 authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

[ios] Move disabled context menu tests to new crbug.

Also disables more affected context menu tests.

Bug: 989550
Change-Id: I9963e6c6dc44f0e255a689c83a878d6db610f342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728539
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682737}
parent adb90ec2
...@@ -162,7 +162,7 @@ void SelectTabAtIndexInCurrentMode(NSUInteger index) { ...@@ -162,7 +162,7 @@ void SelectTabAtIndexInCurrentMode(NSUInteger index) {
@implementation ContextMenuTestCase @implementation ContextMenuTestCase
// TODO(crbug.com/976259) Disable broken context menu tests on Xcode 11 beta 5. // TODO(crbug.com/989550) Disable broken context menu tests on Xcode 11 beta 5.
+ (NSArray*)testInvocations { + (NSArray*)testInvocations {
if (@available(iOS 13, *)) if (@available(iOS 13, *))
return @[]; return @[];
......
...@@ -579,6 +579,13 @@ void TapSuppressDialogsButton() { ...@@ -579,6 +579,13 @@ void TapSuppressDialogsButton() {
// Tests that an alert is presented after a new tab animation is finished. // Tests that an alert is presented after a new tab animation is finished.
- (void)testShowJavaScriptAfterNewTabAnimation { - (void)testShowJavaScriptAfterNewTabAnimation {
// TODO(crbug.com/989550) Disable broken context menu tests on Xc11b5.
if (@available(iOS 13, *)) {
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPad.");
}
}
// Load the test page with a link to kOnLoadAlertURL and long tap on the link. // Load the test page with a link to kOnLoadAlertURL and long tap on the link.
[self loadPageWithLink]; [self loadPageWithLink];
......
...@@ -105,6 +105,11 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse( ...@@ -105,6 +105,11 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse(
} }
- (void)testCopyPaste { - (void)testCopyPaste {
// TODO(crbug.com/989550) Disable broken system callout tests on Xc11b5.
if (@available(iOS 13, *)) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS13.");
}
[self openPage1]; [self openPage1];
// Long pressing should allow copying. // Long pressing should allow copying.
......
...@@ -53,6 +53,13 @@ const char kLinksTestURL2Text[] = "arrived"; ...@@ -53,6 +53,13 @@ const char kLinksTestURL2Text[] = "arrived";
// Tests that new tabs are always inserted after their parent tab. // Tests that new tabs are always inserted after their parent tab.
- (void)testChildTabOrdering { - (void)testChildTabOrdering {
// TODO(crbug.com/989550) Disable broken context menu tests on Xc11b5.
if (@available(iOS 13, *)) {
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPad.");
}
}
GREYAssertTrue(self.testServer->Start(), @"Test server failed to start."); GREYAssertTrue(self.testServer->Start(), @"Test server failed to start.");
const GURL URL1 = self.testServer->GetURL(kLinksTestURL1); const GURL URL1 = self.testServer->GetURL(kLinksTestURL1);
......
...@@ -38,7 +38,7 @@ const char kHtmlFile[] = ...@@ -38,7 +38,7 @@ const char kHtmlFile[] =
@implementation ContextMenuTestCase @implementation ContextMenuTestCase
// TODO(crbug.com/976259) Disable broken context menu tests on Xcode 11 beta 5. // TODO(crbug.com/989550) Disable broken context menu tests on Xcode 11 beta 5.
+ (NSArray*)testInvocations { + (NSArray*)testInvocations {
if (@available(iOS 13, *)) if (@available(iOS 13, *))
return @[]; return @[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment