Gives positioning information for overflow menu.

This CL gives the MenuItem role to each othe overflow menu entries. This
makes it so that positioning information will be readback by ChromeVox.

Bug: 836997
Change-Id: I8e4fad3f9b31d579728c306516e09d887c1390f4
Reviewed-on: https://chromium-review.googlesource.com/c/1392283Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634398}

third_party/blink/renderer/modules/accessibility/ax_media_controls.cc

@@ -60,7 +60,6 @@ AXObject* AccessibilityMediaControl::Create(
 
     case kMediaSliderThumb:
     case kMediaTimelineContainer:
-    case kMediaOverflowList:
       return MakeGarbageCollected<AccessibilityMediaControl>(layout_object,
                                                              ax_object_cache);
     // Removed as a part of the a11y tree rewrite https://crbug/836549.
@@ -103,7 +102,6 @@ String AccessibilityMediaControl::TextAlternative(
   switch (ControlType()) {
     case kMediaSliderThumb:
     case kMediaTimelineContainer:
-    case kMediaOverflowList:
       return QueryString(WebLocalizedString::kAXMediaDefault);
     case kMediaSlider:
     // Removed as a part of the a11y tree rewrite https://crbug/836549.
@@ -123,7 +121,6 @@ String AccessibilityMediaControl::Description(
   switch (ControlType()) {
     case kMediaSliderThumb:
     case kMediaTimelineContainer:
-    case kMediaOverflowList:
       return QueryString(WebLocalizedString::kAXMediaDefault);
     case kMediaSlider:
     // Removed as a part of the a11y tree rewrite https://crbug/836549.
@@ -149,7 +146,6 @@ bool AccessibilityMediaControl::ComputeAccessibilityIsIgnored(
 ax::mojom::Role AccessibilityMediaControl::RoleValue() const {
   switch (ControlType()) {
     case kMediaTimelineContainer:
-    case kMediaOverflowList:
       return ax::mojom::Role::kGroup;
 
     case kMediaSliderThumb:

third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h

@@ -12,7 +12,6 @@ enum MediaControlElementType {
   kMediaSlider,
   kMediaSliderThumb,
   kMediaTimelineContainer,
-  kMediaOverflowList,
   kMediaIgnore
 };
 

third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc

@@ -64,6 +64,7 @@ HTMLElement* MediaControlInputElement::CreateOverflowElement(
   HTMLLabelElement* element = HTMLLabelElement::Create(GetDocument());
   element->SetShadowPseudoId(
       AtomicString("-internal-media-controls-overflow-menu-list-item"));
+  element->setAttribute(html_names::kRoleAttr, "menuitem");
   // Appending a button to a label element ensures that clicks on the label
   // are passed down to the button, performing the action we'd expect.
   element->ParserAppendChild(button);

third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.cc

@@ -18,9 +18,10 @@ namespace blink {
 
 MediaControlOverflowMenuListElement::MediaControlOverflowMenuListElement(
     MediaControlsImpl& media_controls)
-    : MediaControlPopupMenuElement(media_controls, kMediaOverflowList) {
+    : MediaControlPopupMenuElement(media_controls) {
   SetShadowPseudoId(
       AtomicString("-internal-media-controls-overflow-menu-list"));
+  setAttribute(html_names::kRoleAttr, "menu");
   CloseOverflowMenu();
 }
 

third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc

@@ -171,9 +171,8 @@ void MediaControlPopupMenuElement::Trace(blink::Visitor* visitor) {
 }
 
 MediaControlPopupMenuElement::MediaControlPopupMenuElement(
-    MediaControlsImpl& media_controls,
-    MediaControlElementType type)
-    : MediaControlDivElement(media_controls, type) {
+    MediaControlsImpl& media_controls)
+    : MediaControlDivElement(media_controls, kMediaIgnore) {
   SetIsWanted(false);
 }
 

third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.h

@@ -39,7 +39,7 @@ class MediaControlPopupMenuElement : public MediaControlDivElement {
   bool SupportsFocus() const override { return true; }
 
  protected:
-  MediaControlPopupMenuElement(MediaControlsImpl&, MediaControlElementType);
+  MediaControlPopupMenuElement(MediaControlsImpl&);
 
   void SetPosition();
 

third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc

@@ -51,7 +51,7 @@ bool HasDuplicateLabel(TextTrack* current_track) {
 
 MediaControlTextTrackListElement::MediaControlTextTrackListElement(
     MediaControlsImpl& media_controls)
-    : MediaControlPopupMenuElement(media_controls, kMediaIgnore) {
+    : MediaControlPopupMenuElement(media_controls) {
   setAttribute(html_names::kRoleAttr, "menu");
   setAttribute(html_names::kAriaLabelAttr,
                WTF::AtomicString(GetLocale().QueryString(