Commit b601dd5c authored by James Cook's avatar James Cook Committed by Commit Bot

cros: Enable TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu

The underlying accessibility code has been refactored recently and I
cannot reproduce flake locally. Also, the flakiness dashboard shows
that the other tests in the suite are not flaky anymore. I suspect
the issue is fixed.

Also add a RunLoop spin in one place that changes a pref that ash
may need to observe. I don't think that affects this test, but I
noticed it while investigating.

Bug: 787024
Test: browser_tests
Change-Id: I65175c4e87c09c2cc172174c9b0595e4372ad652
Reviewed-on: https://chromium-review.googlesource.com/889645Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532588}
parent 8a187463
......@@ -144,6 +144,8 @@ class TrayAccessibilityTest
if (GetParam() == PREF_SERVICE) {
PrefService* prefs = GetProfile()->GetPrefs();
prefs->SetBoolean(ash::prefs::kShouldAlwaysShowAccessibilityMenu, value);
// Prefs are sent to ash asynchronously.
base::RunLoop().RunUntilIdle();
} else if (GetParam() == POLICY) {
policy::PolicyMap policy_map;
policy_map.Set(policy::key::kShowAccessibilityOptionsInSystemTrayMenu,
......@@ -1584,9 +1586,7 @@ IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, CheckMarksOnDetailMenu) {
CloseDetailMenu();
}
// Flaky: https://crbug.com/787024
IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest,
DISABLED_CheckMenuVisibilityOnDetailMenu) {
IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, CheckMenuVisibilityOnDetailMenu) {
// Except help & settings, others should be kept the same
// in LOGIN | NOT LOGIN | LOCKED. https://crbug.com/632107.
EXPECT_TRUE(CreateDetailedMenu());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment