Commit b60d03a6 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Add GPU ResultDB table

Adds a new resultdb_bigquery_export entry to the GPU team's CI builders,
exporting to luci-resultdb.chromium.gpu_ci_test_results. This is so that
we can query the GPU test results more efficiently for an upcoming
script.

Bug: 1134751
Change-Id: Id4df6f97b920d4d91b2fd7e0e08dd196a3d469f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446893
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Reviewed-by: default avatarNodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814017}
parent ac263bda
This diff is collapsed.
...@@ -426,6 +426,7 @@ def ci_builder( ...@@ -426,6 +426,7 @@ def ci_builder(
console_view_entry = None, console_view_entry = None,
tree_closing = False, tree_closing = False,
notifies = None, notifies = None,
resultdb_bigquery_exports = None,
**kwargs): **kwargs):
"""Define a CI builder. """Define a CI builder.
...@@ -459,6 +460,10 @@ def ci_builder( ...@@ -459,6 +460,10 @@ def ci_builder(
criteria will close the tree and email the sheriff. See the criteria will close the tree and email the sheriff. See the
'chromium-tree-closer' config in notifiers.star for the full criteria. 'chromium-tree-closer' config in notifiers.star for the full criteria.
notifies - Any extra notifiers to attach to this builder. notifies - Any extra notifiers to attach to this builder.
resultdb_bigquery_exports - a list of resultdb.export_test_results(...)
specifying additional parameters for exporting test results to BigQuery.
Will always upload to the luci-resultdb.chromium.ci_test_results table
in addition to any tables specified by the list's elements.
""" """
if not branches.matches(branch_selector): if not branches.matches(branch_selector):
return return
...@@ -469,14 +474,19 @@ def ci_builder( ...@@ -469,14 +474,19 @@ def ci_builder(
if tree_closing and bucket == "ci": if tree_closing and bucket == "ci":
notifies = (notifies or []) + ["chromium-tree-closer", "chromium-tree-closer-email"] notifies = (notifies or []) + ["chromium-tree-closer", "chromium-tree-closer-email"]
merged_resultdb_bigquery_exports = [
resultdb.export_test_results(
bq_table = "luci-resultdb.chromium.ci_test_results",
),
]
merged_resultdb_bigquery_exports.extend(resultdb_bigquery_exports or [])
# Define the builder first so that any validation of luci.builder arguments # Define the builder first so that any validation of luci.builder arguments
# (e.g. bucket) occurs before we try to use it # (e.g. bucket) occurs before we try to use it
builders.builder( builders.builder(
name = name, name = name,
branch_selector = branch_selector, branch_selector = branch_selector,
resultdb_bigquery_exports = [resultdb.export_test_results( resultdb_bigquery_exports = merged_resultdb_bigquery_exports,
bq_table = "luci-resultdb.chromium.ci_test_results",
)],
notifies = notifies, notifies = notifies,
**kwargs **kwargs
) )
...@@ -771,6 +781,15 @@ def fyi_windows_builder( ...@@ -771,6 +781,15 @@ def fyi_windows_builder(
**kwargs **kwargs
) )
gpu_ci_resultdb_exports = [
resultdb.export_test_results(
bq_table = "luci-resultdb.chromium.gpu_ci_test_results",
predicate = resultdb.test_result_predicate(
test_id_regexp = "ninja://chrome/test:telemetry_gpu_integration_test/.+",
),
),
]
def gpu_fyi_builder(*, name, **kwargs): def gpu_fyi_builder(*, name, **kwargs):
return ci.builder( return ci.builder(
name = name, name = name,
...@@ -780,6 +799,7 @@ def gpu_fyi_builder(*, name, **kwargs): ...@@ -780,6 +799,7 @@ def gpu_fyi_builder(*, name, **kwargs):
properties = { properties = {
"perf_dashboard_machine_group": "ChromiumGPUFYI", "perf_dashboard_machine_group": "ChromiumGPUFYI",
}, },
resultdb_bigquery_exports = gpu_ci_resultdb_exports,
**kwargs **kwargs
) )
...@@ -844,6 +864,7 @@ def gpu_builder(*, name, tree_closing = True, notifies = None, **kwargs): ...@@ -844,6 +864,7 @@ def gpu_builder(*, name, tree_closing = True, notifies = None, **kwargs):
builder_group = "chromium.gpu", builder_group = "chromium.gpu",
tree_closing = tree_closing, tree_closing = tree_closing,
notifies = notifies, notifies = notifies,
resultdb_bigquery_exports = gpu_ci_resultdb_exports,
**kwargs **kwargs
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment