Commit b6340b51 authored by Suzy Li's avatar Suzy Li Committed by Commit Bot

Do not support uvm for registration at blink

This CL removes uvm extension support and corresponding counters for
registration at blink layer.

This is the second CL for removing uvm for registration.
The first CL:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1504071

Bug: 986345
Change-Id: Idf74c8a6343609120ac596fd86d2c8d5c7861cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710143Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Reviewed-by: default avatarMartin Kreichgauer <martinkr@google.com>
Commit-Queue: Suzy Li <suzyli@google.com>
Cr-Commit-Position: refs/heads/master@{#681123}
parent 27ca8c41
...@@ -2329,9 +2329,7 @@ enum WebFeature { ...@@ -2329,9 +2329,7 @@ enum WebFeature {
kWebkitMarginAfterCollapseDiscard = 2945, kWebkitMarginAfterCollapseDiscard = 2945,
kWebkitMarginAfterCollapseSeparate = 2946, kWebkitMarginAfterCollapseSeparate = 2946,
kWebkitMarginAfterCollapseSeparateMaybeDoesSomething = 2947, kWebkitMarginAfterCollapseSeparateMaybeDoesSomething = 2947,
kCredentialManagerCreateWithUVM = 2948,
kCredentialManagerGetWithUVM = 2949, kCredentialManagerGetWithUVM = 2949,
kCredentialManagerCreateSuccessWithUVM = 2950,
kCredentialManagerGetSuccessWithUVM = 2951, kCredentialManagerGetSuccessWithUVM = 2951,
kDiscardInputEventToMovingIframe = 2952, kDiscardInputEventToMovingIframe = 2952,
kSignedExchangeSubresourcePrefetch = 2953, kSignedExchangeSubresourcePrefetch = 2953,
......
...@@ -59,8 +59,8 @@ struct CommonCredentialInfo { ...@@ -59,8 +59,8 @@ struct CommonCredentialInfo {
array<uint8> client_data_json; array<uint8> client_data_json;
}; };
// Content of user verification method extension returned by both // Content of user verification method extension returned by
// Authenticator::MakeCredential and Authenticator::GetAssertion. // Authenticator::GetAssertion.
// See https://w3c.github.io/webauthn/#sctn-uvm-extension // See https://w3c.github.io/webauthn/#sctn-uvm-extension
// Registry of the available values, see // Registry of the available values, see
// https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-registry-v2.0-id-20180227.html#user-verification-methods // https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-registry-v2.0-id-20180227.html#user-verification-methods
......
...@@ -405,14 +405,6 @@ void OnMakePublicKeyCredentialComplete( ...@@ -405,14 +405,6 @@ void OnMakePublicKeyCredentialComplete(
if (credential->echo_hmac_create_secret) { if (credential->echo_hmac_create_secret) {
extension_outputs->setHmacCreateSecret(credential->hmac_create_secret); extension_outputs->setHmacCreateSecret(credential->hmac_create_secret);
} }
#if defined(OS_ANDROID)
if (credential->echo_user_verification_methods) {
extension_outputs->setUvm(
UvmEntryToArray(std::move(*credential->user_verification_methods)));
UseCounter::Count(resolver->GetExecutionContext(),
WebFeature::kCredentialManagerCreateSuccessWithUVM);
}
#endif
resolver->Resolve(MakeGarbageCollected<PublicKeyCredential>( resolver->Resolve(MakeGarbageCollected<PublicKeyCredential>(
credential->info->id, raw_id, authenticator_response, credential->info->id, raw_id, authenticator_response,
extension_outputs)); extension_outputs));
...@@ -708,13 +700,6 @@ ScriptPromise CredentialsContainer::create( ...@@ -708,13 +700,6 @@ ScriptPromise CredentialsContainer::create(
resolver->GetExecutionContext(), resolver->GetExecutionContext(),
WebFeature::kCredentialManagerCreatePublicKeyCredential); WebFeature::kCredentialManagerCreatePublicKeyCredential);
} }
#if defined(OS_ANDROID)
if (options->publicKey()->hasExtensions() &&
options->publicKey()->extensions()->hasUvm()) {
UseCounter::Count(resolver->GetExecutionContext(),
WebFeature::kCredentialManagerCreateWithUVM);
}
#endif
const String& relying_party_id = options->publicKey()->rp()->id(); const String& relying_party_id = options->publicKey()->rp()->id();
if (!CheckPublicKeySecurityRequirements(resolver, relying_party_id)) if (!CheckPublicKeySecurityRequirements(resolver, relying_party_id))
......
...@@ -24111,9 +24111,7 @@ Called by update_net_error_codes.py.--> ...@@ -24111,9 +24111,7 @@ Called by update_net_error_codes.py.-->
<int value="2946" label="WebkitMarginAfterCollapseSeparate"/> <int value="2946" label="WebkitMarginAfterCollapseSeparate"/>
<int value="2947" <int value="2947"
label="WebkitMarginAfterCollapseSeparateMaybeDoesSomething"/> label="WebkitMarginAfterCollapseSeparateMaybeDoesSomething"/>
<int value="2948" label="CredentialManagerCreateWithUVM"/>
<int value="2949" label="CredentialManagerGetWithUVM"/> <int value="2949" label="CredentialManagerGetWithUVM"/>
<int value="2950" label="CredentialManagerCreateSuccessWithUVM"/>
<int value="2951" label="CredentialManagerGetSuccessWithUVM"/> <int value="2951" label="CredentialManagerGetSuccessWithUVM"/>
<int value="2952" label="DiscardInputEventToMovingIframe"/> <int value="2952" label="DiscardInputEventToMovingIframe"/>
<int value="2953" label="SignedExchangeSubresourcePrefetch"/> <int value="2953" label="SignedExchangeSubresourcePrefetch"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment