Commit b649d891 authored by Bettina's avatar Bettina Committed by Commit Bot

Expand kPasswordProtectionForSavedPasswords to add domains.

Expand saved password protection experiment to add a flag
on whether or not to show a list of domains in the modal
warning and include a button to route the user to the first
domain that the password was saved on.

Bug: 1015671
Change-Id: I5e5343ea19258ff7fe54044cbdc17e85033edf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867095Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707211}
parent 0dab7330
...@@ -79,6 +79,10 @@ const base::Feature kSendPasswordReusePing { ...@@ -79,6 +79,10 @@ const base::Feature kSendPasswordReusePing {
}; };
#endif #endif
constexpr base::FeatureParam<bool> kShouldShowDomainsForSavedPassword{
&kPasswordProtectionForSavedPasswords, "ShouldShowDomainsForSavedPassword",
false};
const base::Feature kSendSampledPingsForAllowlistDomains{ const base::Feature kSendSampledPingsForAllowlistDomains{
"SafeBrowsingSendSampledPingsForAllowlistDomain", "SafeBrowsingSendSampledPingsForAllowlistDomain",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -158,4 +162,8 @@ bool GetShouldFillOldPhishGuardProto() { ...@@ -158,4 +162,8 @@ bool GetShouldFillOldPhishGuardProto() {
return kShouldFillOldPhishGuardProto.Get(); return kShouldFillOldPhishGuardProto.Get();
} }
bool ShouldShowDomainsForSavedPassword() {
return kShouldShowDomainsForSavedPassword.Get();
}
} // namespace safe_browsing } // namespace safe_browsing
...@@ -107,8 +107,12 @@ base::ListValue GetFeatureStatusList(); ...@@ -107,8 +107,12 @@ base::ListValue GetFeatureStatusList();
// Returns whether or not to stop filling in the SyncAccountType and // Returns whether or not to stop filling in the SyncAccountType and
// ReusedPasswordType enums. This is used in the // ReusedPasswordType enums. This is used in the
// kPasswordProtectionForSignedInUsers experiment. // |kPasswordProtectionForSignedInUsers| experiment.
bool GetShouldFillOldPhishGuardProto(); bool GetShouldFillOldPhishGuardProto();
// Returns whether or not to show a list of domains the saved password was used
// on. This is used in the |kPasswordProtectionForSavedPasswords| experiment.
bool ShouldShowDomainsForSavedPassword();
} // namespace safe_browsing } // namespace safe_browsing
#endif // COMPONENTS_SAFE_BROWSING_FEATURES_H_ #endif // COMPONENTS_SAFE_BROWSING_FEATURES_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment