Commit b65309e2 authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix an instance of bugprone-move-forwarding-reference

Unless it's guaranteed that `std::forward` always turns into an rvalue
ref, using `std::move(x)`, where `x`'s type is a universal reference, is
generally unsafe. `std::forward` is preferred for these cases.

Bug: 1134310
Change-Id: I57310023f83236b42a185d5c1b401ae3a338a94d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443849
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Auto-Submit: George Burgess <gbiv@chromium.org>
Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813019}
parent f532c2da
...@@ -153,7 +153,7 @@ void SystemMediaControlsLinux::InitializeProperties() { ...@@ -153,7 +153,7 @@ void SystemMediaControlsLinux::InitializeProperties() {
// org.mpris.MediaPlayer2 interface properties. // org.mpris.MediaPlayer2 interface properties.
auto set_property = [&](const std::string& property_name, auto&& value) { auto set_property = [&](const std::string& property_name, auto&& value) {
properties_->SetProperty(kMprisAPIInterfaceName, property_name, properties_->SetProperty(kMprisAPIInterfaceName, property_name,
std::move(value), false); std::forward<decltype(value)>(value), false);
}; };
set_property("CanQuit", DbusBoolean(false)); set_property("CanQuit", DbusBoolean(false));
set_property("CanRaise", DbusBoolean(false)); set_property("CanRaise", DbusBoolean(false));
...@@ -171,7 +171,7 @@ void SystemMediaControlsLinux::InitializeProperties() { ...@@ -171,7 +171,7 @@ void SystemMediaControlsLinux::InitializeProperties() {
auto set_player_property = [&](const std::string& property_name, auto set_player_property = [&](const std::string& property_name,
auto&& value) { auto&& value) {
properties_->SetProperty(kMprisAPIPlayerInterfaceName, property_name, properties_->SetProperty(kMprisAPIPlayerInterfaceName, property_name,
std::move(value), false); std::forward<decltype(value)>(value), false);
}; };
set_player_property("PlaybackStatus", DbusString("Stopped")); set_player_property("PlaybackStatus", DbusString("Stopped"));
set_player_property("Rate", DbusDouble(1.0)); set_player_property("Rate", DbusDouble(1.0));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment