Make EXPECT_EQ_UNIQUE_ID() macro use names from its lexical scope.
The macro EXPECT_EQ_UNIQUE_ID() has been defined in a way that expects variables with exact names `expected' and `actual' defined in a dynamic scope, i.e. in the scope of C++ code that actually uses either EXPECT_EQ_UNIQUE_ID() or EXPECT_FORM_FIELD_DATA_EQUALS() macros. It seems the original intent was to use argument expressions passed to EXPECT_FORM_FIELD_DATA_EQUALS(), not necessarily bound to exact names. BUG=896689 Change-Id: I4f782afc1c8ab7c55b77ee111dcbbe64002a4d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757823 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#691079}
Showing
Please register or sign in to comment