Commit b6ae83fd authored by Takuto Ikuta's avatar Takuto Ikuta Committed by Commit Bot

Fix to remove /wd4018 (-Wno-sign-compare) for /chrome_elf

This is a part of effort to remove /wd4018 warning suppression.

Master CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1152755

This CL was uploaded by git cl split.

R=pennymac@chromium.org

Bug: 868248, 588506
Change-Id: Iba8b4516550b89b5acf534bc1fa11d959154550e
Reviewed-on: https://chromium-review.googlesource.com/1152841Reviewed-by: default avatarPenny MacNeil <pennymac@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578846}
parent 1f083a9b
......@@ -543,7 +543,7 @@ TEST_F(ThirdPartyTest, StatusCodes) {
// 3. Confirm key and empty value.
std::vector<ThirdPartyStatus> code_array;
EXPECT_TRUE(QueryStatusCodes(&code_array));
EXPECT_EQ(0, code_array.size());
EXPECT_EQ(0u, code_array.size());
// 4. Add status codes, then verify.
ASSERT_NO_FATAL_FAILURE(
......@@ -553,7 +553,7 @@ TEST_F(ThirdPartyTest, StatusCodes) {
ASSERT_NO_FATAL_FAILURE(
AddStatusCodeForTesting(ThirdPartyStatus::kHookVirtualProtectFailure));
EXPECT_TRUE(QueryStatusCodes(&code_array));
ASSERT_EQ(3, code_array.size());
ASSERT_EQ(3u, code_array.size());
EXPECT_EQ(ThirdPartyStatus::kFileEmpty, code_array[0]);
EXPECT_EQ(ThirdPartyStatus::kLogsCreateMutexFailure, code_array[1]);
EXPECT_EQ(ThirdPartyStatus::kHookVirtualProtectFailure, code_array[2]);
......@@ -561,7 +561,7 @@ TEST_F(ThirdPartyTest, StatusCodes) {
// 5. Reset the registry value to empty.
EXPECT_TRUE(ResetStatusCodesForTesting());
EXPECT_TRUE(QueryStatusCodes(&code_array));
EXPECT_EQ(0, code_array.size());
EXPECT_EQ(0u, code_array.size());
// 6. Disable reg override.
ASSERT_NO_FATAL_FAILURE(CancelRegRedirect(nt::HKCU));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment