Commit b6bf5c32 authored by ncbray@chromium.org's avatar ncbray@chromium.org

Roll gtest and gmock DEPS.

These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.

This CL was originally landed as 288164 and reverted as 288239 because it allows
more aggressive LTO in MSVS. This resulted in the compiler noticing an
intentional arithmetic overflow and warning about it.

BUG=401761

Review URL: https://codereview.chromium.org/425333002

Cr-Commit-Position: refs/heads/master@{#288505}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288505 0039d316-1c4b-4281-b951-d872f2087c98
parent 97af9a26
......@@ -100,10 +100,10 @@ deps = {
(Var("googlecode_url") % "open-vcdiff") + "/trunk@42",
"src/testing/gtest":
(Var("googlecode_url") % "googletest") + "/trunk@643",
(Var("googlecode_url") % "googletest") + "/trunk@692",
"src/testing/gmock":
(Var("googlecode_url") % "googlemock") + "/trunk@410",
(Var("googlecode_url") % "googlemock") + "/trunk@485",
"src/third_party/angle":
Var("chromium_git") + "/angle/angle.git@" + Var("angle_revision"),
......
......@@ -34,6 +34,13 @@ inline void ResetFloatingPointUnit() {
#endif
}
// These tests deliberately cause arithmetic overflows. If the compiler is
// aggressive enough, it can const fold these overflows. Disable warnings about
// overflows for const expressions.
#if defined(OS_WIN)
#pragma warning(disable:4756)
#endif
// Helper macros to wrap displaying the conversion types and line numbers.
#define TEST_EXPECTED_VALIDITY(expected, actual) \
EXPECT_EQ(expected, CheckedNumeric<Dst>(actual).validity()) \
......
......@@ -14,6 +14,8 @@ config("gtest_config") {
# In order to allow regex matches in gtest to be shared between Windows
# and other systems, we tell gtest to always use it's internal engine.
"GTEST_HAS_POSIX_RE=0",
# Chrome doesn't support / require C++11, yet.
"GTEST_LANG_CXX11=0",
]
# Gtest headers need to be able to find themselves.
......
......@@ -37,6 +37,7 @@
'gmock.h',
'gmock-matchers.h',
'gmock-more-actions.h',
'gmock-more-matchers.h',
'gmock-spec-builders.h',
],
'DEST': 'include/gmock',
......
......@@ -55,10 +55,13 @@
# In order to allow regex matches in gtest to be shared between Windows
# and other systems, we tell gtest to always use it's internal engine.
'GTEST_HAS_POSIX_RE=0',
# Chrome doesn't support / require C++11, yet.
'GTEST_LANG_CXX11=0',
],
'all_dependent_settings': {
'defines': [
'GTEST_HAS_POSIX_RE=0',
'GTEST_LANG_CXX11=0',
],
},
'conditions': [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment