Commit b6c1d7cd authored by rogerta@chromium.org's avatar rogerta@chromium.org

The password manager infobar is suppressed when the one-click infobar is

supposed to show itself.  However, in this case the problem was that the
later was not showing.  The problem is that the one-click infobar triggers
on the http header "Google-Accounts-Signin", which it was looking in the
headers of 302 redirect responses, but in some cases it can also appear in
200 responses.

BUG=132849
TEST=Make sure that the one-click infobar is always shown in the right
conditions.  I'm not sure how to trigger a sign in without all the redirects.
I was only able to repro this bug on on Windows XP machine.


Review URL: https://chromiumcodereview.appspot.com/10827404

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152405 0039d316-1c4b-4281-b951-d872f2087c98
parent 21a1a185
...@@ -343,6 +343,14 @@ void ChromeResourceDispatcherHostDelegate::OnResponseStarted( ...@@ -343,6 +343,14 @@ void ChromeResourceDispatcherHostDelegate::OnResponseStarted(
AutoLoginPrompter::ShowInfoBarIfPossible(request, info->GetChildID(), AutoLoginPrompter::ShowInfoBarIfPossible(request, info->GetChildID(),
info->GetRouteID()); info->GetRouteID());
#if defined(ENABLE_ONE_CLICK_SIGNIN)
// See if the response contains the Google-Accounts-SignIn header. If so,
// then the user has just finished signing in, and the server is allowing the
// browser to suggest connecting the user's profile to the account.
OneClickSigninHelper::ShowInfoBarIfPossible(request, info->GetChildID(),
info->GetRouteID());
#endif
ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context); ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
if (io_data->resource_prefetch_predictor_observer()) if (io_data->resource_prefetch_predictor_observer())
io_data->resource_prefetch_predictor_observer()->OnResponseStarted(request); io_data->resource_prefetch_predictor_observer()->OnResponseStarted(request);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment