Commit b6cec2c8 authored by Mike Jackson's avatar Mike Jackson Committed by Commit Bot

dpwas: Update RecordAppWindowLaunch to get winning display mode for telemetry

Ensure that we log the winning display mode from the manifest
accounting for display_override.

To test the change use: chrome --enable-features=WebAppManifestDisplayOverride
Example websites:
 https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html
 (display == browser, display_override == [standard])

Image of chrome://histograms
https://imgur.com/a/aVzadhf

Explainer: https://github.com/WICG/display-override/blob/master/explainer.m
Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing
I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion

Bug: 1109520
Change-Id: Ie401fd770eae262c9ad6d7e76e3d7e21d6a285c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354531Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#797862}
parent 9014dabc
......@@ -349,8 +349,8 @@ IN_PROC_BROWSER_TEST_P(WebAppBrowserTest_DisplayOverride, HasMinimalUiButtons) {
AppId app_id = InstallWebApp(std::move(web_app_info));
Browser* app_browser = LaunchWebAppBrowser(app_id);
DCHECK(app_browser->app_controller());
tester.ExpectUniqueSample(kLaunchWebAppDisplayModeHistogram, display_mode,
1);
tester.ExpectUniqueSample(kLaunchWebAppDisplayModeHistogram,
display_override_mode, 1);
bool matches;
EXPECT_TRUE(ExecuteScriptAndExtractBool(
......
......@@ -293,7 +293,8 @@ void RecordAppWindowLaunch(Profile* profile, const std::string& app_id) {
if (!provider)
return;
DisplayMode display = provider->registrar().GetAppDisplayMode(app_id);
DisplayMode display =
provider->registrar().GetEffectiveDisplayModeFromManifest(app_id);
if (display == DisplayMode::kUndefined)
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment