Skip to content

GitLab

T
tangled
Commit b6e7e373 authored by Xida Chen's avatar Xida Chen Committed by Commit Bot
Browse files
Options

Deflake svg-stroke-dasharray-interpolation.html 

Looking at the flakiness dashboard, it looks like this test times out
on dbg bots only (where the timeout limit is 18s). When it doesn't time
out, it takes 15-17s to finish the test.

The test itself contains 19 sub-tests, I think the proper solution is to
break the test into 2 tests, just like the "svg-d-interpolation" tests.

Bug: 875170
Change-Id: Ic38b651061634b47ce66fb2e53033a61611a35ad
Reviewed-on: https://chromium-review.googlesource.com/c/1361595Reviewed-by: default avatarStephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613716}
parent a175f2f2
Hide whitespace changes
Inline Side-by-side
Showing with 146 additions and 121 deletions
third_party/blink/web_tests/TestExpectations
View file @ b6e7e373
...@@ -5489,9 +5489,6 @@ crbug.com/874733 [ Android ] accessibility/aria-labelledby-on-input.html [ Crash ...@@ -5489,9 +5489,6 @@ crbug.com/874733 [ Android ] accessibility/aria-labelledby-on-input.html [ Crash
crbug.com/874733 [ Android ] accessibility/aria-link-supports-press.html [ Crash ] crbug.com/874733 [ Android ] accessibility/aria-link-supports-press.html [ Crash ]
crbug.com/874733 [ Android ] accessibility/insert-adjacent-html-causes-crash.xhtml [ Crash ] crbug.com/874733 [ Android ] accessibility/insert-adjacent-html-causes-crash.xhtml [ Crash ]
# Sheriff 2018-08-17
crbug.com/875170 animations/interpolation/svg-stroke-dasharray-interpolation.html [ Timeout Pass ]
# Test frequently times out on Mac CQ bots. # Test frequently times out on Mac CQ bots.
crbug.com/874703 [ Mac ] http/tests/devtools/extensions/extensions-panel.js [ Timeout Pass ] crbug.com/874703 [ Mac ] http/tests/devtools/extensions/extensions-panel.js [ Timeout Pass ]
......
third_party/blink/web_tests/animations/interpolation/svg-stroke-dasharray-interpolation-001.html 0 → 100644
View file @ b6e7e373
<!DOCTYPE html>
<meta charset="UTF-8">
<style>
.container {
display: inline-block;
}
.parent {
stroke-dasharray: 30 10;
}
.target {
font-size: 16px;
stroke: black;
stroke-width: 10px;
stroke-dasharray: 10 30;
}
.expected {
stroke: green;
}
</style>
<body>
<template id="target-template">
<svg height="400" width="5">
<path d="M0,0 l0,400" class="target">
</svg>
</template>
<script src="resources/interpolation-test.js"></script>
<script>
assertInterpolation({
property: 'stroke-dasharray',
from: neutralKeyframe,
to: '20 20',
}, [
{at: -0.6, is: '4px, 36px'},
{at: -0.4, is: '6px, 34px'},
{at: -0.2, is: '8px, 32px'},
{at: 0, is: '10px, 30px'},
{at: 0.2, is: '12px, 28px'},
{at: 0.4, is: '14px, 26px'},
{at: 0.6, is: '16px, 24px'},
{at: 0.8, is: '18px, 22px'},
{at: 1, is: '20px, 20px'},
{at: 1.2, is: '22px, 18px'},
]);
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'initial',
to: '20 20',
});
assertInterpolation({
property: 'stroke-dasharray',
from: 'inherit',
to: '20 20',
}, [
{at: -0.6, is: '36px, 4px'},
{at: -0.4, is: '34px, 6px'},
{at: -0.2, is: '32px, 8px'},
{at: 0, is: '30px, 10px'},
{at: 0.2, is: '28px, 12px'},
{at: 0.4, is: '26px, 14px'},
{at: 0.6, is: '24px, 16px'},
{at: 0.8, is: '22px, 18px'},
{at: 1, is: '20px, 20px'},
{at: 1.2, is: '18px, 22px'},
]);
assertInterpolation({
property: 'stroke-dasharray',
from: 'unset',
to: '20 20',
}, [
{at: -0.6, is: '36px, 4px'},
{at: -0.4, is: '34px, 6px'},
{at: -0.2, is: '32px, 8px'},
{at: 0, is: '30px, 10px'},
{at: 0.2, is: '28px, 12px'},
{at: 0.4, is: '26px, 14px'},
{at: 0.6, is: '24px, 16px'},
{at: 0.8, is: '22px, 18px'},
{at: 1, is: '20px, 20px'},
{at: 1.2, is: '18px, 22px'},
]);
// Basic case
assertInterpolation({
property: 'stroke-dasharray',
from: '5 10',
to: '15 20'
}, [
{at: -0.6, is: ' 0 4'}, // Values must be non-negative.
{at: -0.4, is: ' 1 6'},
{at: -0.2, is: ' 3 8'},
{at: 0, is: ' 5 10'},
{at: 0.2, is: ' 7 12'},
{at: 0.4, is: ' 9 14'},
{at: 0.6, is: '11 16'},
{at: 0.8, is: '13 18'},
{at: 1, is: '15 20'},
{at: 1.2, is: '17 22'},
]);
// Zero value
assertInterpolation({
property: 'stroke-dasharray',
from: '0 0',
to: '5 10'
}, [
{at: -0.2, is: ' 0 0'}, // Values must be non-negative.
{at: 0, is: ' 0 0'},
{at: 0.2, is: ' 1 2'},
{at: 0.4, is: ' 2 4'},
{at: 0.6, is: ' 3 6'},
{at: 0.8, is: ' 4 8'},
{at: 1.0, is: ' 5 10'},
{at: 1.2, is: ' 6 12'},
]);
// From none
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'none',
to: '5 10'
});
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'none',
to: '5em 10em'
});
// To none
assertNoInterpolation({
property: 'stroke-dasharray',
from: '5 10',
to: 'none'
});
// Both none
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'none',
to: 'none'
});
</script>
</body>
third_party/blink/web_tests/animations/interpolation/svg-stroke-dasharray-interpolation.html → third_party/blink/web_tests/animations/interpolation/svg-stroke-dasharray-interpolation-002.html
View file @ b6e7e373
...@@ -25,124 +25,6 @@ ...@@ -25,124 +25,6 @@
</template> </template>
<script src="resources/interpolation-test.js"></script> <script src="resources/interpolation-test.js"></script>
<script> <script>
assertInterpolation({
property: 'stroke-dasharray',
from: neutralKeyframe,
to: '20 20',
}, [
{at: -0.6, is: '4px, 36px'},
{at: -0.4, is: '6px, 34px'},
{at: -0.2, is: '8px, 32px'},
{at: 0, is: '10px, 30px'},
{at: 0.2, is: '12px, 28px'},
{at: 0.4, is: '14px, 26px'},
{at: 0.6, is: '16px, 24px'},
{at: 0.8, is: '18px, 22px'},
{at: 1, is: '20px, 20px'},
{at: 1.2, is: '22px, 18px'},
]);
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'initial',
to: '20 20',
});
assertInterpolation({
property: 'stroke-dasharray',
from: 'inherit',
to: '20 20',
}, [
{at: -0.6, is: '36px, 4px'},
{at: -0.4, is: '34px, 6px'},
{at: -0.2, is: '32px, 8px'},
{at: 0, is: '30px, 10px'},
{at: 0.2, is: '28px, 12px'},
{at: 0.4, is: '26px, 14px'},
{at: 0.6, is: '24px, 16px'},
{at: 0.8, is: '22px, 18px'},
{at: 1, is: '20px, 20px'},
{at: 1.2, is: '18px, 22px'},
]);
assertInterpolation({
property: 'stroke-dasharray',
from: 'unset',
to: '20 20',
}, [
{at: -0.6, is: '36px, 4px'},
{at: -0.4, is: '34px, 6px'},
{at: -0.2, is: '32px, 8px'},
{at: 0, is: '30px, 10px'},
{at: 0.2, is: '28px, 12px'},
{at: 0.4, is: '26px, 14px'},
{at: 0.6, is: '24px, 16px'},
{at: 0.8, is: '22px, 18px'},
{at: 1, is: '20px, 20px'},
{at: 1.2, is: '18px, 22px'},
]);
// Basic case
assertInterpolation({
property: 'stroke-dasharray',
from: '5 10',
to: '15 20'
}, [
{at: -0.6, is: ' 0 4'}, // Values must be non-negative.
{at: -0.4, is: ' 1 6'},
{at: -0.2, is: ' 3 8'},
{at: 0, is: ' 5 10'},
{at: 0.2, is: ' 7 12'},
{at: 0.4, is: ' 9 14'},
{at: 0.6, is: '11 16'},
{at: 0.8, is: '13 18'},
{at: 1, is: '15 20'},
{at: 1.2, is: '17 22'},
]);
// Zero value
assertInterpolation({
property: 'stroke-dasharray',
from: '0 0',
to: '5 10'
}, [
{at: -0.2, is: ' 0 0'}, // Values must be non-negative.
{at: 0, is: ' 0 0'},
{at: 0.2, is: ' 1 2'},
{at: 0.4, is: ' 2 4'},
{at: 0.6, is: ' 3 6'},
{at: 0.8, is: ' 4 8'},
{at: 1.0, is: ' 5 10'},
{at: 1.2, is: ' 6 12'},
]);
// From none
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'none',
to: '5 10'
});
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'none',
to: '5em 10em'
});
// To none
assertNoInterpolation({
property: 'stroke-dasharray',
from: '5 10',
to: 'none'
});
// Both none
assertNoInterpolation({
property: 'stroke-dasharray',
from: 'none',
to: 'none'
});
// Differing list lengths // Differing list lengths
// Lists are repeated until length is equal to lowest common multiple of lengths. // Lists are repeated until length is equal to lowest common multiple of lengths.
assertInterpolation({ assertInterpolation({
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment