Commit b7098f55 authored by Mohamed Heikal's avatar Mohamed Heikal Committed by Commit Bot

Make doubledown rolled packages private

We should ensure that no new usages of the real targets can be added.

Change-Id: I4999c2257f9aedef38809c4f182f419c8bed058c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357452
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: default avatarSam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799813}
parent 91362c52
...@@ -4078,7 +4078,7 @@ if (enable_java_templates) { ...@@ -4078,7 +4078,7 @@ if (enable_java_templates) {
chromium_code = false chromium_code = false
sources = [] sources = []
srcjar_deps = [ ":${_template_name}__protoc_java" ] srcjar_deps = [ ":${_template_name}__protoc_java" ]
deps = [ android_proto_runtime ] deps = [ "//third_party/android_deps:protobuf_lite_runtime_java" ]
if (defined(invoker.deps)) { if (defined(invoker.deps)) {
deps += invoker.deps deps += invoker.deps
} }
......
...@@ -1395,6 +1395,10 @@ android_aar_prebuilt("com_google_android_material_material_java") { ...@@ -1395,6 +1395,10 @@ android_aar_prebuilt("com_google_android_material_material_java") {
# Reduce binary size. https:crbug.com/954584 # Reduce binary size. https:crbug.com/954584
ignore_proguard_configs = true ignore_proguard_configs = true
# Material Design is pulled in via Doubledown, thus this target should not
# be directly depended on. Please use :material_design_java instead.
visibility = [ ":*" ]
} }
# This is generated, do not edit. Update BuildConfigGenerator.groovy instead. # This is generated, do not edit. Update BuildConfigGenerator.groovy instead.
...@@ -1582,6 +1586,10 @@ java_prebuilt("com_google_protobuf_protobuf_javalite_java") { ...@@ -1582,6 +1586,10 @@ java_prebuilt("com_google_protobuf_protobuf_javalite_java") {
output_name = "com_google_protobuf_protobuf_javalite" output_name = "com_google_protobuf_protobuf_javalite"
supports_android = true supports_android = true
# Protobuf runtime is pulled in via Doubledown, thus this target should not
# be directly depended on. Please use :protobuf_lite_runtime_java instead.
visibility = [ ":*" ]
# Prebuilt protos in the runtime library. # Prebuilt protos in the runtime library.
# If you want to use these protos, you should create a proto_java_library # If you want to use these protos, you should create a proto_java_library
# target for them. See crbug.com/1103399 for discussion. # target for them. See crbug.com/1103399 for discussion.
......
...@@ -343,6 +343,10 @@ class BuildConfigGenerator extends DefaultTask { ...@@ -343,6 +343,10 @@ class BuildConfigGenerator extends DefaultTask {
sb.append('\n') sb.append('\n')
sb.append(' # Reduce binary size. https:crbug.com/954584\n') sb.append(' # Reduce binary size. https:crbug.com/954584\n')
sb.append(' ignore_proguard_configs = true\n') sb.append(' ignore_proguard_configs = true\n')
sb.append('\n')
sb.append(' # Material Design is pulled in via Doubledown, thus this target should not\n')
sb.append(' # be directly depended on. Please use :material_design_java instead.\n')
sb.append(' visibility = [ ":*" ]\n')
break break
case 'com_android_support_support_annotations': case 'com_android_support_support_annotations':
sb.append(' # https://crbug.com/989505\n') sb.append(' # https://crbug.com/989505\n')
...@@ -443,6 +447,10 @@ class BuildConfigGenerator extends DefaultTask { ...@@ -443,6 +447,10 @@ class BuildConfigGenerator extends DefaultTask {
sb.append(' ignore_manifest = true\n') sb.append(' ignore_manifest = true\n')
break break
case 'com_google_protobuf_protobuf_javalite': case 'com_google_protobuf_protobuf_javalite':
sb.append(' # Protobuf runtime is pulled in via Doubledown, thus this target should not\n')
sb.append(' # be directly depended on. Please use :protobuf_lite_runtime_java instead.\n')
sb.append(' visibility = [ ":*" ]\n')
sb.append('\n')
sb.append(' # Prebuilt protos in the runtime library.\n') sb.append(' # Prebuilt protos in the runtime library.\n')
sb.append(' # If you want to use these protos, you should create a proto_java_library\n') sb.append(' # If you want to use these protos, you should create a proto_java_library\n')
sb.append(' # target for them. See crbug.com/1103399 for discussion.\n') sb.append(' # target for them. See crbug.com/1103399 for discussion.\n')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment