Commit b722095c authored by Mihai Sardarescu's avatar Mihai Sardarescu Committed by Commit Bot

Re-enable tests for gaia_auth_fetcher_ios_ns_url_session_bridge_unittests

We are preparing to enable by default the feature
kUseNSURLSessionForGaiaSigninRequests. This CL enables the tests of
the bridge that were deemed flaky.

Fixed: 1065349

Change-Id: I5408f4ed70463503fd00cf06cc6e6f649cdfa00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247771
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782983}
parent 6ebe0da6
...@@ -326,9 +326,7 @@ GaiaAuthFetcherIOSNSURLSessionBridgeTest::GetHeaderFieldsWithCookies( ...@@ -326,9 +326,7 @@ GaiaAuthFetcherIOSNSURLSessionBridgeTest::GetHeaderFieldsWithCookies(
// Tests to send a request with no cookies set in the cookie store and receive // Tests to send a request with no cookies set in the cookie store and receive
// multiples cookies from the request. // multiples cookies from the request.
// TODO(crbug.com/1065349): this test is flaky. TEST_F(GaiaAuthFetcherIOSNSURLSessionBridgeTest, FetchWithEmptyCookieStore) {
TEST_F(GaiaAuthFetcherIOSNSURLSessionBridgeTest,
DISABLED_FetchWithEmptyCookieStore) {
ns_url_session_bridge_->Fetch(GetFetchGURL(), "", "", false); ns_url_session_bridge_->Fetch(GetFetchGURL(), "", "", false);
OCMExpect([http_cookie_storage_mock_ OCMExpect([http_cookie_storage_mock_
storeCookies:@[] storeCookies:@[]
...@@ -373,8 +371,7 @@ TEST_F(GaiaAuthFetcherIOSNSURLSessionBridgeTest, ...@@ -373,8 +371,7 @@ TEST_F(GaiaAuthFetcherIOSNSURLSessionBridgeTest,
// Tests to a request with a redirect. One cookie is received by the first // Tests to a request with a redirect. One cookie is received by the first
// request, and a second one by the redirected request. // request, and a second one by the redirected request.
// TODO(crbug.com/1065349): this test is flaky. TEST_F(GaiaAuthFetcherIOSNSURLSessionBridgeTest, FetchWithRedirect) {
TEST_F(GaiaAuthFetcherIOSNSURLSessionBridgeTest, DISABLED_FetchWithRedirect) {
ns_url_session_bridge_->Fetch(GetFetchGURL(), "", "", false); ns_url_session_bridge_->Fetch(GetFetchGURL(), "", "", false);
OCMExpect([http_cookie_storage_mock_ OCMExpect([http_cookie_storage_mock_
storeCookies:@[] storeCookies:@[]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment