Remove NetworkIsolationKey::Todo() in test files.

This is used to track areas where we need to fill in empty
NetworkIsolationKeys with the correct value. While we certainly should
add tests when we do this, keeping Todo()s in tests makes it harder to
audit the production code where we need to wire up NIKs.

Bug: None
Change-Id: I99fcca16a2b2d9a266444512c19bddaba2cc77a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222524
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773241}

net/extras/sqlite/sqlite_persistent_reporting_and_nel_store_unittest.cc

@@ -199,8 +199,7 @@ class SQLitePersistentReportingAndNelStoreTest
     info.priority = priority;
     info.weight = weight;
     ReportingEndpoint endpoint(
-        ReportingEndpointGroupKey(NetworkIsolationKey::Todo(), origin,
-                                  group_name),
+        ReportingEndpointGroupKey(NetworkIsolationKey(), origin, group_name),
         std::move(info));
     return endpoint;
   }
@@ -212,8 +211,7 @@ class SQLitePersistentReportingAndNelStoreTest
       OriginSubdomains include_subdomains = OriginSubdomains::DEFAULT,
       base::Time expires = kExpires) {
     return CachedReportingEndpointGroup(
-        ReportingEndpointGroupKey(NetworkIsolationKey::Todo(), origin,
-                                  group_name),
+        ReportingEndpointGroupKey(NetworkIsolationKey(), origin, group_name),
         include_subdomains, expires, last_used);
   }
 

net/reporting/reporting_browsing_data_remover_unittest.cc

@@ -43,15 +43,15 @@ class ReportingBrowsingDataRemoverTest : public ReportingTestBase {
 
   // TODO(chlily): Take NIK.
   void AddReport(const GURL& url) {
-    cache()->AddReport(NetworkIsolationKey::Todo(), url, kUserAgent_, kGroup_,
-                       kType_, std::make_unique<base::DictionaryValue>(), 0,
+    cache()->AddReport(NetworkIsolationKey(), url, kUserAgent_, kGroup_, kType_,
+                       std::make_unique<base::DictionaryValue>(), 0,
                        tick_clock()->NowTicks(), 0);
   }
 
   // TODO(chlily): Take NIK.
   void SetEndpoint(const url::Origin& origin) {
     SetEndpointInCache(
-        ReportingEndpointGroupKey(NetworkIsolationKey::Todo(), origin, kGroup_),
+        ReportingEndpointGroupKey(NetworkIsolationKey(), origin, kGroup_),
         kEndpoint_, base::Time::Now() + base::TimeDelta::FromDays(7));
   }
 
@@ -154,14 +154,12 @@ TEST_F(ReportingBrowsingDataRemoverTest, RemoveSomeClients) {
   RemoveBrowsingData(/* remove_reports= */ false, /* remove_clients= */ true,
                      /* host= */ kUrl1_.host());
   EXPECT_EQ(2u, report_count());
-  EXPECT_FALSE(
-      FindEndpointInCache(ReportingEndpointGroupKey(NetworkIsolationKey::Todo(),
-                                                    kOrigin1_, kGroup_),
-                          kEndpoint_));
-  EXPECT_TRUE(
-      FindEndpointInCache(ReportingEndpointGroupKey(NetworkIsolationKey::Todo(),
-                                                    kOrigin2_, kGroup_),
-                          kEndpoint_));
+  EXPECT_FALSE(FindEndpointInCache(
+      ReportingEndpointGroupKey(NetworkIsolationKey(), kOrigin1_, kGroup_),
+      kEndpoint_));
+  EXPECT_TRUE(FindEndpointInCache(
+      ReportingEndpointGroupKey(NetworkIsolationKey(), kOrigin2_, kGroup_),
+      kEndpoint_));
 }
 
 }  // namespace

net/reporting/reporting_service_unittest.cc

@@ -44,11 +44,9 @@ class ReportingServiceTest : public ::testing::TestWithParam<bool>,
   const std::string kGroup_ = "group";
   const std::string kType_ = "type";
   const ReportingEndpointGroupKey kGroupKey_ =
-      ReportingEndpointGroupKey(NetworkIsolationKey::Todo(), kOrigin_, kGroup_);
+      ReportingEndpointGroupKey(NetworkIsolationKey(), kOrigin_, kGroup_);
   const ReportingEndpointGroupKey kGroupKey2_ =
-      ReportingEndpointGroupKey(NetworkIsolationKey::Todo(),
-                                kOrigin2_,
-                                kGroup_);
+      ReportingEndpointGroupKey(NetworkIsolationKey(), kOrigin2_, kGroup_);
 
   ReportingServiceTest() {
     if (GetParam())