Commit b72a85ef authored by Andrey Kosyakov's avatar Andrey Kosyakov Committed by Commit Bot

Expect browser_ may be null in HeadlessDevToolsManagerDelegate

... it's a WeakPtr after all.

Bug: 1140263
Change-Id: I4bcc7890f67b1220b756d97c53c64de012c52756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488988Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819239}
parent 282cbfb2
......@@ -72,6 +72,8 @@ void HeadlessDevToolsManagerDelegate::ClientDetached(
std::vector<content::BrowserContext*>
HeadlessDevToolsManagerDelegate::GetBrowserContexts() {
std::vector<content::BrowserContext*> contexts;
if (!browser_)
return contexts;
for (auto* context : browser_->GetAllBrowserContexts()) {
if (context != browser_->GetDefaultBrowserContext())
contexts.push_back(HeadlessBrowserContextImpl::From(context));
......@@ -80,11 +82,15 @@ HeadlessDevToolsManagerDelegate::GetBrowserContexts() {
}
content::BrowserContext*
HeadlessDevToolsManagerDelegate::GetDefaultBrowserContext() {
return HeadlessBrowserContextImpl::From(browser_->GetDefaultBrowserContext());
return browser_ ? HeadlessBrowserContextImpl::From(
browser_->GetDefaultBrowserContext())
: nullptr;
}
content::BrowserContext*
HeadlessDevToolsManagerDelegate::CreateBrowserContext() {
if (!browser_)
return nullptr;
auto builder = browser_->CreateBrowserContextBuilder();
builder.SetIncognitoMode(true);
HeadlessBrowserContext* browser_context = builder.Build();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment