Omnibox - Launch Change to Correctly Classify Typed Visits

Delete the omnibox experiment and launch the new behavior unconditionally.

BUG=369989,468908

Review-Url: https://codereview.chromium.org/2351443002
Cr-Commit-Position: refs/heads/master@{#419578}

components/omnibox/browser/omnibox_field_trial.cc

@@ -401,12 +401,6 @@ float OmniboxFieldTrial::HQPExperimentalTopicalityThreshold() {
   return static_cast<float>(topicality_threshold);
 }
 
-bool OmniboxFieldTrial::HQPFixTypedVisitBug() {
-  return variations::GetVariationParamValue(
-      kBundledExperimentFieldTrialName,
-      kHQPFixTypedVisitBugRule) == "true";
-}
-
 bool OmniboxFieldTrial::HQPFixFewVisitsBug() {
   return variations::GetVariationParamValue(
       kBundledExperimentFieldTrialName,
@@ -513,8 +507,6 @@ OmniboxFieldTrial::kMeasureSuggestPollingDelayFromLastKeystrokeRule[] =
     "MeasureSuggestPollingDelayFromLastKeystroke";
 const char OmniboxFieldTrial::kSuggestPollingDelayMsRule[] =
     "SuggestPollingDelayMs";
-const char OmniboxFieldTrial::kHQPFixTypedVisitBugRule[] =
-    "HQPFixTypedVisitBug";
 const char OmniboxFieldTrial::kHQPFixFewVisitsBugRule[] = "HQPFixFewVisitsBug";
 const char OmniboxFieldTrial::kHQPNumTitleWordsRule[] = "HQPNumTitleWords";
 const char OmniboxFieldTrial::kHQPAlsoDoHUPLikeScoringRule[] =

components/omnibox/browser/omnibox_field_trial.h

@@ -291,10 +291,6 @@ class OmniboxFieldTrial {
   // For the HQPFixFrequencyScoring experiment that's part of the
   // bundled omnibox field trial.
 
-  // Returns true if HQP should apply the bug fix for correctly identifying
-  // typed visits.
-  static bool HQPFixTypedVisitBug();
-
   // Returns true if HQP should apply the bug fix to discount the visits to
   // pages visited less than ten times.
   static bool HQPFixFewVisitsBug();
@@ -375,7 +371,6 @@ class OmniboxFieldTrial {
   static const char kDisableResultsCachingRule[];
   static const char kMeasureSuggestPollingDelayFromLastKeystrokeRule[];
   static const char kSuggestPollingDelayMsRule[];
-  static const char kHQPFixTypedVisitBugRule[];
   static const char kHQPFixFewVisitsBugRule[];
   static const char kHQPNumTitleWordsRule[];
   static const char kHQPAlsoDoHUPLikeScoringRule[];

components/omnibox/browser/scored_history_match.cc

@@ -108,7 +108,6 @@ void InitDaysAgoToRecencyScoreArray() {
 const size_t ScoredHistoryMatch::kMaxVisitsToScore = 10;
 bool ScoredHistoryMatch::also_do_hup_like_scoring_ = false;
 int ScoredHistoryMatch::bookmark_value_ = 1;
-bool ScoredHistoryMatch::fix_typed_visit_bug_ = false;
 bool ScoredHistoryMatch::fix_few_visits_bug_ = false;
 bool ScoredHistoryMatch::allow_tld_matches_ = false;
 bool ScoredHistoryMatch::allow_scheme_matches_ = false;
@@ -420,7 +419,6 @@ void ScoredHistoryMatch::Init() {
   initialized = true;
   also_do_hup_like_scoring_ = OmniboxFieldTrial::HQPAlsoDoHUPLikeScoring();
   bookmark_value_ = OmniboxFieldTrial::HQPBookmarkValue();
-  fix_typed_visit_bug_ = OmniboxFieldTrial::HQPFixTypedVisitBug();
   fix_few_visits_bug_ = OmniboxFieldTrial::HQPFixFewVisitsBug();
   allow_tld_matches_ = OmniboxFieldTrial::HQPAllowMatchInTLDValue();
   allow_scheme_matches_ = OmniboxFieldTrial::HQPAllowMatchInSchemeValue();
@@ -597,11 +595,8 @@ float ScoredHistoryMatch::GetFrequency(const base::Time& now,
   const size_t max_visit_to_score =
       std::min(visits.size(), ScoredHistoryMatch::kMaxVisitsToScore);
   for (size_t i = 0; i < max_visit_to_score; ++i) {
-    const bool is_page_transition_typed =
-        fix_typed_visit_bug_ ? ui::PageTransitionCoreTypeIs(
-                                   visits[i].second, ui::PAGE_TRANSITION_TYPED)
-                             : ui::PageTransitionTypeIncludingQualifiersIs(
-                                   visits[i].second, ui::PAGE_TRANSITION_TYPED);
+    const bool is_page_transition_typed = ui::PageTransitionCoreTypeIs(
+        visits[i].second, ui::PAGE_TRANSITION_TYPED);
     int value_of_transition = is_page_transition_typed ? 20 : 1;
     if (bookmarked)
       value_of_transition = std::max(value_of_transition, bookmark_value_);

components/omnibox/browser/scored_history_match.h

@@ -168,8 +168,8 @@ struct ScoredHistoryMatch : public history::HistoryMatch {
   // untyped visits to non-bookmarked pages and 20 for typed visits.
   static int bookmark_value_;
 
-  // True if we should fix certain bugs in frequency scoring.
-  static bool fix_typed_visit_bug_;
+  // True if we should fix a bug in frequency scoring relating to how we
+  // extrapolate frecency when the URL has been visited few times.
   static bool fix_few_visits_bug_;
 
   // If true, we allow input terms to match in the TLD (e.g., ".com").