Commit b754cf33 authored by Dominique Fauteux-Chapleau's avatar Dominique Fauteux-Chapleau Committed by Commit Bot

Add ".gz" and ".csv" to supported DLP types

Change-Id: Ide49e3143b84c77e73baf09dad79e95f4d732c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141440
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757469}
parent 61b8c367
...@@ -1232,9 +1232,11 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) { ...@@ -1232,9 +1232,11 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) {
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.7z")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.7z"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.bzip")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.bzip"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.cab")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.cab"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.csv"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.doc")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.doc"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.docx")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.docx"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.eps")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.eps"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.tar.gz"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.gzip")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.gzip"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.odt")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.odt"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.pdf")); data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.pdf"));
...@@ -1262,8 +1264,8 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) { ...@@ -1262,8 +1264,8 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) {
base::BindOnce( base::BindOnce(
[](bool* called, const DeepScanningDialogDelegate::Data& data, [](bool* called, const DeepScanningDialogDelegate::Data& data,
const DeepScanningDialogDelegate::Result& result) { const DeepScanningDialogDelegate::Result& result) {
EXPECT_EQ(21u, data.paths.size()); EXPECT_EQ(23u, data.paths.size());
EXPECT_EQ(21u, result.paths_results.size()); EXPECT_EQ(23u, result.paths_results.size());
// The supported types should be marked as false. // The supported types should be marked as false.
for (const auto& result : result.paths_results) for (const auto& result : result.paths_results)
......
...@@ -230,13 +230,14 @@ void RecordDeepScanMetrics(DeepScanAccessPoint access_point, ...@@ -230,13 +230,14 @@ void RecordDeepScanMetrics(DeepScanAccessPoint access_point,
50); 50);
} }
std::array<const base::FilePath::CharType*, 21> SupportedDlpFileTypes() { std::array<const base::FilePath::CharType*, 23> SupportedDlpFileTypes() {
// Keep sorted for efficient access. // Keep sorted for efficient access.
static constexpr const std::array<const base::FilePath::CharType*, 21> static constexpr const std::array<const base::FilePath::CharType*, 23>
kSupportedDLPFileTypes = { kSupportedDLPFileTypes = {
FILE_PATH_LITERAL(".7z"), FILE_PATH_LITERAL(".bzip"), FILE_PATH_LITERAL(".7z"), FILE_PATH_LITERAL(".bzip"),
FILE_PATH_LITERAL(".cab"), FILE_PATH_LITERAL(".doc"), FILE_PATH_LITERAL(".cab"), FILE_PATH_LITERAL(".csv"),
FILE_PATH_LITERAL(".docx"), FILE_PATH_LITERAL(".eps"), FILE_PATH_LITERAL(".doc"), FILE_PATH_LITERAL(".docx"),
FILE_PATH_LITERAL(".eps"), FILE_PATH_LITERAL(".gz"),
FILE_PATH_LITERAL(".gzip"), FILE_PATH_LITERAL(".odt"), FILE_PATH_LITERAL(".gzip"), FILE_PATH_LITERAL(".odt"),
FILE_PATH_LITERAL(".pdf"), FILE_PATH_LITERAL(".ppt"), FILE_PATH_LITERAL(".pdf"), FILE_PATH_LITERAL(".ppt"),
FILE_PATH_LITERAL(".pptx"), FILE_PATH_LITERAL(".ps"), FILE_PATH_LITERAL(".pptx"), FILE_PATH_LITERAL(".ps"),
......
...@@ -77,7 +77,7 @@ void RecordDeepScanMetrics(DeepScanAccessPoint access_point, ...@@ -77,7 +77,7 @@ void RecordDeepScanMetrics(DeepScanAccessPoint access_point,
bool success); bool success);
// Returns an array of the file types supported for DLP scanning. // Returns an array of the file types supported for DLP scanning.
std::array<const base::FilePath::CharType*, 21> SupportedDlpFileTypes(); std::array<const base::FilePath::CharType*, 23> SupportedDlpFileTypes();
// Returns true if the given file type is supported for DLP scanning. // Returns true if the given file type is supported for DLP scanning.
bool FileTypeSupported(bool for_malware_scan, bool FileTypeSupported(bool for_malware_scan,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment