Commit b77a54f6 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Include otool for Telemetry

Includes the hermetic Xcode binary directory as a data dependency for
Telemetry tests on Mac. Xcode is required in order to symbolize
minidumps on Mac, and this previously worked by accident due to Xcode
previously being installed system-wide. generate_breakpad_symbols.py
already supports using the hermetic binary, so we just need to ensure
that it's available on a swarming task.

Also re-enables the tests that were disabled due to the missing Xcode
binaries.

Bug: 1110441
Change-Id: Icb703e08c65c27c4b6300710033be138a0bd4da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324883
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792823}
parent 48d8b520
......@@ -125,6 +125,14 @@ group("telemetry_chrome_test_without_chrome") {
]
}
if (is_mac) {
data += [
# Required for the hermetic otool binary, which is required for
# symbolizing minidumps on Mac.
"//build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/",
]
}
if (is_android) {
data += [
# TODO(httpss://crbug.com/833808): Remove this once bots always set
......
......@@ -35,7 +35,6 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
# still read-only, so skip the test in that case.
@decorators.Disabled(
'chromeos-local',
'mac', #https://crbug.com/1110441
'win' # https://crbug.com/1084931
)
def testSymbolizeMinidump(self):
......@@ -81,7 +80,6 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
# still read-only, so skip the test in that case.
@decorators.Disabled(
'chromeos-local',
'mac', # https://crbug.com/1110441
'win' # https://crbug.com/1084931
)
def testMultipleCrashMinidumps(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment