Commit b78083ae authored by Yue Zhang's avatar Yue Zhang Committed by Commit Bot

Skip testShowWithAnimation test on Nexus 5X devices

TabListContainerViewBinderTest#testShowWithAnimation is failing on
Android CFI bot. This CL disables this test on Nexus 5X to skip this
bot.

Bug: 954145, 1023530
Change-Id: I386ada2bee2959568e4b9dc09913ee6fa8c3db10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913171Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715389}
parent 9aab1ef2
...@@ -25,7 +25,7 @@ import org.junit.runner.RunWith; ...@@ -25,7 +25,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ApiCompatibilityUtils; import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.CommandLine; import org.chromium.base.CommandLine;
import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.DisabledTest; import org.chromium.base.test.util.DisableIf;
import org.chromium.chrome.browser.ChromeFeatureList; import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.flags.FeatureUtilities; import org.chromium.chrome.browser.flags.FeatureUtilities;
import org.chromium.chrome.tab_ui.R; import org.chromium.chrome.tab_ui.R;
...@@ -113,10 +113,12 @@ public class TabListContainerViewBinderTest extends DummyUiActivityTestCase { ...@@ -113,10 +113,12 @@ public class TabListContainerViewBinderTest extends DummyUiActivityTestCase {
@Test @Test
@MediumTest @MediumTest
// clang-format off
@Features.EnableFeatures(ChromeFeatureList.TAB_TO_GTS_ANIMATION) @Features.EnableFeatures(ChromeFeatureList.TAB_TO_GTS_ANIMATION)
@DisabledTest @DisableIf.Build(hardware_is = "bullhead", message = "Flaky on CFI bot. " +
// Failed multiple times on Android CFI https://crbug.com/954145 "https://crbug.com/954145")
public void testShowWithAnimation() { public void testShowWithAnimation() {
// clang-format on
TestThreadUtils.runOnUiThreadBlocking(() -> { TestThreadUtils.runOnUiThreadBlocking(() -> {
mContainerModel.set( mContainerModel.set(
TabListContainerProperties.VISIBILITY_LISTENER, mMockVisibilityListener); TabListContainerProperties.VISIBILITY_LISTENER, mMockVisibilityListener);
...@@ -124,7 +126,6 @@ public class TabListContainerViewBinderTest extends DummyUiActivityTestCase { ...@@ -124,7 +126,6 @@ public class TabListContainerViewBinderTest extends DummyUiActivityTestCase {
mContainerModel.set(TabListContainerProperties.ANIMATE_VISIBILITY_CHANGES, true); mContainerModel.set(TabListContainerProperties.ANIMATE_VISIBILITY_CHANGES, true);
mContainerModel.set(TabListContainerProperties.IS_VISIBLE, true); mContainerModel.set(TabListContainerProperties.IS_VISIBLE, true);
}); });
assertThat(mStartedShowingCallback.getCallCount(), equalTo(1)); assertThat(mStartedShowingCallback.getCallCount(), equalTo(1));
assertThat(mRecyclerView.getVisibility(), equalTo(View.VISIBLE)); assertThat(mRecyclerView.getVisibility(), equalTo(View.VISIBLE));
if (areAnimatorsEnabled()) { if (areAnimatorsEnabled()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment