Commit b7873821 authored by Sergey Poromov's avatar Sergey Poromov Committed by Commit Bot

Disabling flaky GCMDriverBaseTest tests on ASan

The following tests sometimes fail with a memory leak:
GCMDriverBaseTest.SendWebPushMessage
GCMDriverBaseTest.SendWebPushMessageServerError
GCMDriverFunctionalTest.UnregisterRemovesEncryptionInfo

Example:
https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/384983

TBR=peter@chromium.org

Bug: 1009185
Change-Id: Icb4bb3cc40116cf98a29b56c83a9ceb3566c5597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831799Reviewed-by: default avatarSergey Poromov <poromov@chromium.org>
Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701069}
parent 809b17e3
......@@ -688,7 +688,12 @@ TEST_F(GCMDriverFunctionalTest, UnregisterExplicitly) {
EXPECT_EQ(GCMClient::SUCCESS, unregistration_result());
}
// TODO(crbug.com/1009185): Test is failing on ASan build.
#if defined(ADDRESS_SANITIZER)
TEST_F(GCMDriverFunctionalTest, DISABLED_UnregisterRemovesEncryptionInfo) {
#else
TEST_F(GCMDriverFunctionalTest, UnregisterRemovesEncryptionInfo) {
#endif
std::vector<std::string> sender_ids;
sender_ids.push_back("sender1");
Register(kTestAppID1, sender_ids, GCMDriverTest::WAIT);
......
......@@ -277,7 +277,12 @@ void GCMDriverBaseTest::DecryptMessageCompleted(
async_operation_completed_callback_.Run();
}
// TODO(crbug.com/1009185): Test is failing on ASan build.
#if defined(ADDRESS_SANITIZER)
TEST_F(GCMDriverBaseTest, DISABLED_SendWebPushMessage) {
#else
TEST_F(GCMDriverBaseTest, SendWebPushMessage) {
#endif
GetEncryptionInfo(kTestAppID1, GCMDriverBaseTest::WAIT);
WebPushMessage message;
......@@ -316,7 +321,12 @@ TEST_F(GCMDriverBaseTest, SendWebPushMessageEncryptionError) {
EXPECT_FALSE(send_web_push_message_id());
}
// TODO(crbug.com/1009185): Test is failing on ASan build.
#if defined(ADDRESS_SANITIZER)
TEST_F(GCMDriverBaseTest, DISABLED_SendWebPushMessageServerError) {
#else
TEST_F(GCMDriverBaseTest, SendWebPushMessageServerError) {
#endif
GetEncryptionInfo(kTestAppID1, GCMDriverBaseTest::WAIT);
WebPushMessage message;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment