Commit b79af6a8 authored by Xing Liu's avatar Xing Liu Committed by Commit Bot

Fix flaky NotificationIntentInterceptorTest.

This CL enable a flaky test:
NotificationIntentInterceptorTest#testContentIntentInterception

Bug: 906843
Change-Id: Icf92bbd5fae556b0faf1c1a6c5b2bf65c0016449
Reviewed-on: https://chromium-review.googlesource.com/c/1353949Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612752}
parent 7f8de314
...@@ -25,7 +25,7 @@ import org.junit.runner.RunWith; ...@@ -25,7 +25,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest; import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ChromeTabbedActivity; import org.chromium.chrome.browser.ChromeTabbedActivity;
...@@ -65,9 +65,8 @@ public class NotificationIntentInterceptorTest { ...@@ -65,9 +65,8 @@ public class NotificationIntentInterceptorTest {
Uri uri = Uri.parse("www.example.com"); Uri uri = Uri.parse("www.example.com");
contentIntent.setData(uri); contentIntent.setData(uri);
contentIntent.setAction(Intent.ACTION_VIEW); contentIntent.setAction(Intent.ACTION_VIEW);
int flags = PendingIntent.FLAG_ONE_SHOT;
PendingIntent contentPendingIntent = PendingIntent contentPendingIntent =
PendingIntent.getActivity(context, 0, contentIntent, flags); PendingIntent.getActivity(context, 0, contentIntent, 0);
assert contentPendingIntent != null; assert contentPendingIntent != null;
builder.setContentIntent(NotificationIntentInterceptor.createInterceptPendingIntent( builder.setContentIntent(NotificationIntentInterceptor.createInterceptPendingIntent(
NotificationIntentInterceptor.IntentType.CONTENT_INTENT, contentPendingIntent)); NotificationIntentInterceptor.IntentType.CONTENT_INTENT, contentPendingIntent));
...@@ -84,9 +83,9 @@ public class NotificationIntentInterceptorTest { ...@@ -84,9 +83,9 @@ public class NotificationIntentInterceptorTest {
private void clickNotification(String text) { private void clickNotification(String text) {
UiDevice device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()); UiDevice device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation());
device.openNotification(); device.openNotification();
device.wait( device.wait(Until.hasObject(By.textContains(text)),
Until.hasObject(By.text(text)), WAIT_FOR_NOTIFICATION_SHOWN_TIMEOUT_MILLISECONDS); WAIT_FOR_NOTIFICATION_SHOWN_TIMEOUT_MILLISECONDS);
UiObject2 textObject = device.findObject(By.text(text)); UiObject2 textObject = device.findObject(By.textContains(text));
Assert.assertEquals(text, textObject.getText()); Assert.assertEquals(text, textObject.getText());
textObject.click(); textObject.click();
} }
...@@ -99,12 +98,13 @@ public class NotificationIntentInterceptorTest { ...@@ -99,12 +98,13 @@ public class NotificationIntentInterceptorTest {
*/ */
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "Flaky on Kitkat, crbug.com/906843") @RetryOnFailure
public void testContentIntentInterception() { public void testContentIntentInterception() {
// Send notification. // Send notification.
NotificationManager notificationManager = NotificationManager notificationManager =
(NotificationManager) ContextUtils.getApplicationContext().getSystemService( (NotificationManager) ContextUtils.getApplicationContext().getSystemService(
Context.NOTIFICATION_SERVICE); Context.NOTIFICATION_SERVICE);
notificationManager.cancelAll();
notificationManager.notify(0, buildSimpleNotification(TEST_NOTIFICATION_TITLE)); notificationManager.notify(0, buildSimpleNotification(TEST_NOTIFICATION_TITLE));
// Click notification body. // Click notification body.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment