Commit b7a682b6 authored by bcwhite's avatar bcwhite Committed by Commit bot

Try to fix gathering of ranges_ptr plus capture checksums.

BUG=600717

Review-Url: https://codereview.chromium.org/2362113002
Cr-Commit-Position: refs/heads/master@{#420613}
parent e8bb0272
...@@ -53,6 +53,8 @@ void HistogramSnapshotManager::PrepareSamples( ...@@ -53,6 +53,8 @@ void HistogramSnapshotManager::PrepareSamples(
for (size_t i = 0; i < ranges->size(); ++i) for (size_t i = 0; i < ranges->size(); ++i)
ranges_copy.push_back(ranges->range(i)); ranges_copy.push_back(ranges->range(i));
HistogramBase::Sample* ranges_ptr = &ranges_copy[0]; HistogramBase::Sample* ranges_ptr = &ranges_copy[0];
uint32_t ranges_checksum = ranges->checksum();
uint32_t ranges_calc_checksum = ranges->CalculateChecksum();
const char* histogram_name = histogram->histogram_name().c_str(); const char* histogram_name = histogram->histogram_name().c_str();
int32_t flags = histogram->flags(); int32_t flags = histogram->flags();
// The checksum should have caught this, so crash separately if it didn't. // The checksum should have caught this, so crash separately if it didn't.
...@@ -60,7 +62,9 @@ void HistogramSnapshotManager::PrepareSamples( ...@@ -60,7 +62,9 @@ void HistogramSnapshotManager::PrepareSamples(
CHECK(false); // Crash for the bucket order corruption. CHECK(false); // Crash for the bucket order corruption.
// Ensure that compiler keeps around pointers to |histogram| and its // Ensure that compiler keeps around pointers to |histogram| and its
// internal |bucket_ranges_| for any minidumps. // internal |bucket_ranges_| for any minidumps.
base::debug::Alias(&ranges_ptr); base::debug::Alias(ranges_ptr);
base::debug::Alias(&ranges_checksum);
base::debug::Alias(&ranges_calc_checksum);
base::debug::Alias(&histogram_name); base::debug::Alias(&histogram_name);
base::debug::Alias(&flags); base::debug::Alias(&flags);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment