Commit b7b3408a authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Chrome OS OOBE: Remove continueUrl parameter

Remove the "continueUrl" parameter from the cr.login.Authenticator's
load() method, and remove associated code.

This parameter has been unused since crrev.com/c/1605419.

Bug: 470893
Test: existing tests,
      manual test: checking that OOBE enrollment, OOBE login,
      adding a new user on Chrome OS and desktop platforms work

Change-Id: Ic6dfd663f22fc792fe6da2c7102f0f2548b769e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604274Reviewed-by: default avatarDenis Kuznetsov <antrim@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660619}
parent 7ee9a0a2
...@@ -21,8 +21,6 @@ cr.define('cr.login', function() { ...@@ -21,8 +21,6 @@ cr.define('cr.login', function() {
// of hardcoding the prod URL here. As is, this does not work with staging // of hardcoding the prod URL here. As is, this does not work with staging
// environments. // environments.
const IDP_ORIGIN = 'https://accounts.google.com/'; const IDP_ORIGIN = 'https://accounts.google.com/';
const CONTINUE_URL =
'chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/success.html';
const SIGN_IN_HEADER = 'google-accounts-signin'; const SIGN_IN_HEADER = 'google-accounts-signin';
const EMBEDDED_FORM_HEADER = 'google-accounts-embedded'; const EMBEDDED_FORM_HEADER = 'google-accounts-embedded';
const LOCATION_HEADER = 'location'; const LOCATION_HEADER = 'location';
...@@ -61,7 +59,6 @@ cr.define('cr.login', function() { ...@@ -61,7 +59,6 @@ cr.define('cr.login', function() {
'gaiaPath', // Gaia path to use without a leading slash. 'gaiaPath', // Gaia path to use without a leading slash.
'hl', // Language code for the user interface. 'hl', // Language code for the user interface.
'service', // Name of Gaia service. 'service', // Name of Gaia service.
'continueUrl', // Continue url to use.
'frameUrl', // Initial frame URL to use. If empty defaults to 'frameUrl', // Initial frame URL to use. If empty defaults to
// gaiaUrl. // gaiaUrl.
'constrained', // Whether the extension is loaded in a constrained 'constrained', // Whether the extension is loaded in a constrained
...@@ -132,8 +129,6 @@ cr.define('cr.login', function() { ...@@ -132,8 +129,6 @@ cr.define('cr.login', function() {
this.authDomain = ''; this.authDomain = '';
this.videoEnabled = false; this.videoEnabled = false;
this.idpOrigin_ = null; this.idpOrigin_ = null;
this.continueUrl_ = null;
this.continueUrlWithoutParams_ = null;
this.initialFrameUrl_ = null; this.initialFrameUrl_ = null;
this.reloadUrl_ = null; this.reloadUrl_ = null;
this.trusted_ = true; this.trusted_ = true;
...@@ -286,10 +281,6 @@ cr.define('cr.login', function() { ...@@ -286,10 +281,6 @@ cr.define('cr.login', function() {
// gaiaUrl parameter is used for testing. Once defined, it is never // gaiaUrl parameter is used for testing. Once defined, it is never
// changed. // changed.
this.idpOrigin_ = data.gaiaUrl || IDP_ORIGIN; this.idpOrigin_ = data.gaiaUrl || IDP_ORIGIN;
this.continueUrl_ = data.continueUrl || CONTINUE_URL;
this.continueUrlWithoutParams_ =
this.continueUrl_.substring(0, this.continueUrl_.indexOf('?')) ||
this.continueUrl_;
this.isConstrainedWindow_ = data.constrained == '1'; this.isConstrainedWindow_ = data.constrained == '1';
this.clientId_ = data.clientId; this.clientId_ = data.clientId;
this.dontResizeNonEmbeddedPages = data.dontResizeNonEmbeddedPages; this.dontResizeNonEmbeddedPages = data.dontResizeNonEmbeddedPages;
......
...@@ -122,8 +122,6 @@ void InlineLoginHandler::ContinueHandleInitializeMessage() { ...@@ -122,8 +122,6 @@ void InlineLoginHandler::ContinueHandleInitializeMessage() {
params.SetBoolean("isLoginPrimaryAccount", true); params.SetBoolean("isLoginPrimaryAccount", true);
} }
params.SetString("continueUrl", signin::GetLandingURL(access_point).spec());
Profile* profile = Profile::FromWebUI(web_ui()); Profile* profile = Profile::FromWebUI(web_ui());
std::string default_email; std::string default_email;
if (reason == signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT || if (reason == signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT ||
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment