Commit b7b39c2d authored by Xinghui Lu's avatar Xinghui Lu Committed by Commit Bot

Remove SendOnFocusPing and SendPasswordReusePing flags.

The flags were used for launches on Android in M79. They were set to
enable by default in M81. They will be removed in this CL in M82.

Bug: 995926
Change-Id: I8035064bafd38e3eb239c345e5cde0c5074a6402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095703Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748559}
parent f59ec658
...@@ -102,9 +102,6 @@ void PasswordProtectionService::MaybeStartPasswordFieldOnFocusRequest( ...@@ -102,9 +102,6 @@ void PasswordProtectionService::MaybeStartPasswordFieldOnFocusRequest(
const std::string& hosted_domain) { const std::string& hosted_domain) {
DCHECK_CURRENTLY_ON(BrowserThread::UI); DCHECK_CURRENTLY_ON(BrowserThread::UI);
RequestOutcome reason; RequestOutcome reason;
if (!base::FeatureList::IsEnabled(safe_browsing::kSendOnFocusPing)) {
return;
}
if (CanSendPing(LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE, if (CanSendPing(LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE,
main_frame_url, main_frame_url,
GetPasswordProtectionReusedPasswordAccountType( GetPasswordProtectionReusedPasswordAccountType(
...@@ -129,9 +126,6 @@ void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest( ...@@ -129,9 +126,6 @@ void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest(
const std::vector<std::string>& matching_domains, const std::vector<std::string>& matching_domains,
bool password_field_exists) { bool password_field_exists) {
DCHECK_CURRENTLY_ON(BrowserThread::UI); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!base::FeatureList::IsEnabled(safe_browsing::kSendPasswordReusePing)) {
return;
}
ReusedPasswordAccountType reused_password_account_type = ReusedPasswordAccountType reused_password_account_type =
GetPasswordProtectionReusedPasswordAccountType(password_type, username); GetPasswordProtectionReusedPasswordAccountType(password_type, username);
RequestOutcome reason; RequestOutcome reason;
......
...@@ -103,16 +103,6 @@ const base::Feature kSafeBrowsingAvailableOnIOS{ ...@@ -103,16 +103,6 @@ const base::Feature kSafeBrowsingAvailableOnIOS{
const base::Feature kSafeBrowsingSeparateNetworkContexts{ const base::Feature kSafeBrowsingSeparateNetworkContexts{
"SafeBrowsingSeparateNetworkContexts", base::FEATURE_DISABLED_BY_DEFAULT}; "SafeBrowsingSeparateNetworkContexts", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kSendOnFocusPing {
"SafeBrowsingSendOnFocusPing",
base::FEATURE_ENABLED_BY_DEFAULT
};
const base::Feature kSendPasswordReusePing {
"SafeBrowsingSendPasswordReusePing",
base::FEATURE_ENABLED_BY_DEFAULT
};
constexpr base::FeatureParam<bool> kShouldFillOldPhishGuardProto{ constexpr base::FeatureParam<bool> kShouldFillOldPhishGuardProto{
&kPasswordProtectionForSignedInUsers, "DeprecateOldProto", false}; &kPasswordProtectionForSignedInUsers, "DeprecateOldProto", false};
...@@ -154,8 +144,6 @@ constexpr struct { ...@@ -154,8 +144,6 @@ constexpr struct {
{&kRealTimeUrlLookupEnabledWithToken, true}, {&kRealTimeUrlLookupEnabledWithToken, true},
{&kSafeBrowsingAvailableOnIOS, true}, {&kSafeBrowsingAvailableOnIOS, true},
{&kSafeBrowsingSeparateNetworkContexts, true}, {&kSafeBrowsingSeparateNetworkContexts, true},
{&kSendOnFocusPing, true},
{&kSendPasswordReusePing, true},
{&kSuspiciousSiteTriggerQuotaFeature, true}, {&kSuspiciousSiteTriggerQuotaFeature, true},
{&kThreatDomDetailsTagAndAttributeFeature, false}, {&kThreatDomDetailsTagAndAttributeFeature, false},
{&kTriggerThrottlerDailyQuotaFeature, false}, {&kTriggerThrottlerDailyQuotaFeature, false},
......
...@@ -82,12 +82,6 @@ extern const base::Feature kSafeBrowsingAvailableOnIOS; ...@@ -82,12 +82,6 @@ extern const base::Feature kSafeBrowsingAvailableOnIOS;
// profile. // profile.
extern const base::Feature kSafeBrowsingSeparateNetworkContexts; extern const base::Feature kSafeBrowsingSeparateNetworkContexts;
// Controls whether Chrome sends on focus ping.
extern const base::Feature kSendOnFocusPing;
// Controls whether Chrome sends password reuse ping.
extern const base::Feature kSendPasswordReusePing;
// Controls the daily quota for the suspicious site trigger. // Controls the daily quota for the suspicious site trigger.
extern const base::Feature kSuspiciousSiteTriggerQuotaFeature; extern const base::Feature kSuspiciousSiteTriggerQuotaFeature;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment