Commit b7c5acff authored by Ken Rockot's avatar Ken Rockot Committed by Commit Bot

Mojo: Add CHECK to debug possible random name collisions

BUG=725605
TBR=jcivelli@chromium.org

Change-Id: I5106c8073e021929abc36797710a88e667949b23
Reviewed-on: https://chromium-review.googlesource.com/575651Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487366}
parent 8a2484bd
......@@ -132,8 +132,14 @@ int Node::CreateUninitializedPort(PortRef* port_ref) {
scoped_refptr<Port> port(new Port(kInitialSequenceNum, kInitialSequenceNum));
int rv = AddPortWithName(port_name, port);
if (rv != OK)
if (rv != OK) {
// TODO(crbug.com/725605): Remove this CHECK. This is testing whether or not
// random port name generation is somehow resulting in insufficiently random
// and thus colliding names in the wild, which would be one explanation for
// some of the weird behavior we're seeing.
CHECK(false);
return rv;
}
*port_ref = PortRef(port_name, std::move(port));
return OK;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment