Tab Search: Uplift Tab Search bubble tests

Adds test cases for Tab Search bubble. Updates ShowUI test to anchor
to the Tab Search button.

Bug: 1099917
Change-Id: Id1440d383e73ed3bb6e983fa0b62db1fa8c933da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436689
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812433}

chrome/browser/ui/views/tab_search/tab_search_bubble_view.h

@@ -56,6 +56,8 @@ class TabSearchBubbleView : public views::BubbleDialogDelegateView,
 
   void OnWebViewSizeChanged();
 
+  views::WebView* web_view_for_testing() { return web_view_; }
+
  private:
   views::WebView* web_view_;
 

chrome/browser/ui/views/tab_search/tab_search_bubble_view_browsertest.cc

@@ -12,15 +12,100 @@
 #include "chrome/browser/ui/test/test_browser_dialog.h"
 #include "chrome/browser/ui/ui_features.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/tabs/tab_search_button.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 #include "chrome/common/webui_url_constants.h"
 #include "content/public/test/browser_test.h"
+#include "ui/views/bubble/bubble_dialog_delegate_view.h"
 
-class TabSearchBubbleBrowserTest : public DialogBrowserTest {
+class TabSearchBubbleBrowserTest : public InProcessBrowserTest {
  public:
   TabSearchBubbleBrowserTest() {
     feature_list_.InitAndEnableFeature(features::kTabSearch);
   }
+  TabSearchBubbleBrowserTest(TabSearchBubbleBrowserTest&) = delete;
+  TabSearchBubbleBrowserTest& operator=(TabSearchBubbleBrowserTest&) = delete;
+  ~TabSearchBubbleBrowserTest() override = default;
+
+  // InProcessBrowserTest:
+  void SetUpOnMainThread() override {
+    auto* anchor = BrowserView::GetBrowserViewForBrowser(browser())->toolbar();
+    auto bubble_delegate =
+        std::make_unique<TabSearchBubbleView>(browser()->profile(), anchor);
+    bubble_view_ = bubble_delegate.get();
+    bubble_ = views::BubbleDialogDelegateView::CreateBubble(
+        bubble_delegate.release());
+  }
+
+  views::Widget* bubble() { return bubble_; }
+  TabSearchBubbleView* bubble_view() { return bubble_view_; }
+
+ private:
+  views::Widget* bubble_ = nullptr;
+  TabSearchBubbleView* bubble_view_ = nullptr;
+  base::test::ScopedFeatureList feature_list_;
+};
+
+IN_PROC_BROWSER_TEST_F(TabSearchBubbleBrowserTest, TestShowAndCloseBubble) {
+  EXPECT_NE(nullptr, bubble());
+
+  // Test showing the bubble via ShowBubble() method.
+  EXPECT_FALSE(bubble()->IsVisible());
+  bubble_view()->ShowBubble();
+  EXPECT_TRUE(bubble()->IsVisible());
+
+  // Test closing the bubble via CloseBubble() method.
+  EXPECT_FALSE(bubble()->IsClosed());
+  bubble_view()->CloseBubble();
+  EXPECT_TRUE(bubble()->IsClosed());
+
+  bubble()->CloseNow();
+}
+
+IN_PROC_BROWSER_TEST_F(TabSearchBubbleBrowserTest, TestBubbleResize) {
+  EXPECT_NE(nullptr, bubble());
+
+  // Show the bubble
+  EXPECT_FALSE(bubble()->IsVisible());
+  bubble_view()->ShowBubble();
+  EXPECT_TRUE(bubble()->IsVisible());
+
+  views::WebView* const web_view = bubble_view()->web_view_for_testing();
+  constexpr gfx::Size web_view_initial_size(100, 100);
+  web_view->SetPreferredSize(gfx::Size(100, 100));
+  bubble_view()->OnWebViewSizeChanged();
+  const gfx::Size widget_initial_size =
+      bubble()->GetWindowBoundsInScreen().size();
+  // The bubble should be at least as big as the webview.
+  EXPECT_GE(widget_initial_size.width(), web_view_initial_size.width());
+  EXPECT_GE(widget_initial_size.height(), web_view_initial_size.height());
+
+  // Resize the webview.
+  constexpr gfx::Size web_view_final_size(200, 200);
+  web_view->SetPreferredSize(web_view_final_size);
+  bubble_view()->OnWebViewSizeChanged();
+
+  // Ensure the bubble resizes as expected.
+  const gfx::Size widget_final_size =
+      bubble()->GetWindowBoundsInScreen().size();
+  EXPECT_LT(widget_initial_size.width(), widget_final_size.width());
+  EXPECT_LT(widget_initial_size.height(), widget_final_size.height());
+  // The bubble should be at least as big as the webview.
+  EXPECT_GE(widget_final_size.width(), web_view_final_size.width());
+  EXPECT_GE(widget_final_size.height(), web_view_final_size.height());
+
+  bubble()->CloseNow();
+}
+
+class TabSearchBubbleBrowserUITest : public DialogBrowserTest {
+ public:
+  TabSearchBubbleBrowserUITest() {
+    feature_list_.InitAndEnableFeature(features::kTabSearch);
+  }
+  TabSearchBubbleBrowserUITest(TabSearchBubbleBrowserUITest&) = delete;
+  TabSearchBubbleBrowserUITest& operator=(TabSearchBubbleBrowserUITest&) =
+      delete;
+  ~TabSearchBubbleBrowserUITest() override = default;
 
   // DialogBrowserTest:
   void ShowUi(const std::string& name) override {
@@ -30,7 +115,7 @@ class TabSearchBubbleBrowserTest : public DialogBrowserTest {
     BrowserView* browser_view =
         BrowserView::GetBrowserViewForBrowser(browser());
     DCHECK(browser_view);
-    views::View* anchor_view = browser_view->toolbar();
+    views::View* anchor_view = browser_view->GetTabSearchButton();
     TabSearchBubbleView::CreateTabSearchBubble(browser()->profile(),
                                                anchor_view);
   }
@@ -41,10 +126,9 @@ class TabSearchBubbleBrowserTest : public DialogBrowserTest {
 
  private:
   base::test::ScopedFeatureList feature_list_;
-  DISALLOW_COPY_AND_ASSIGN(TabSearchBubbleBrowserTest);
 };
 
 // Invokes a tab search bubble.
-IN_PROC_BROWSER_TEST_F(TabSearchBubbleBrowserTest, InvokeUi_default) {
+IN_PROC_BROWSER_TEST_F(TabSearchBubbleBrowserUITest, InvokeUi_default) {
   ShowAndVerifyUi();
 }