Skip to content

GitLab

T
tangled
Commit b7d172c3 authored by vabr@chromium.org's avatar vabr@chromium.org
Browse files
Options

PasswordManager browser test: simplify checking for password prompt 

Currently, every single test case needs to check whether the infobar or tha password bubble is used, and do different checks accordingly. Even worse, auto-saving behaviour is different for those two, so people modifying existing tests are very likely to have false expectations.

This CL creates a PromptObserver class by decoupling prompt observing from navigation observation. PromptObserver takes care of the differences between infobar and bubble automatically, and provides a clear API to check for the prompt being shown, and to instruct the prompt to save passwords, respectively.

BUG=392144

Review URL: https://codereview.chromium.org/378643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282772 0039d316-1c4b-4281-b951-d872f2087c98
parent e088f02c
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 210 additions and 194 deletions
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment