Commit b7e66685 authored by Francois Beaufort's avatar Francois Beaufort Committed by Commit Bot

[WebNFC] Add UKM counters

This CL adds UKM counters to NDEFReader.scan and NDEFWriter.push.

Bug: 520391
Change-Id: I33e8f8ad90b20871eb24622531c93ce387d873f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910089
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: default avatarRijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#717597}
parent 188816bc
......@@ -2473,6 +2473,8 @@ enum WebFeature {
kResourceTimingTaintedOriginFlagFail = 3091,
kRegisterProtocolHandlerSameOriginAsTop = 3092,
kRegisterProtocolHandlerCrossOriginSubframe = 3093,
kWebNfcNdefReaderScan = 3094,
kWebNfcNdefWriterPush = 3095,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
......
......@@ -16,6 +16,7 @@
#include "third_party/blink/renderer/modules/nfc/ndef_scan_options.h"
#include "third_party/blink/renderer/modules/nfc/nfc_proxy.h"
#include "third_party/blink/renderer/modules/nfc/nfc_utils.h"
#include "third_party/blink/renderer/platform/instrumentation/use_counter.h"
#include "third_party/blink/renderer/platform/weborigin/kurl.h"
namespace blink {
......@@ -117,6 +118,8 @@ ScriptPromise NDEFReader::scan(ScriptState* script_state,
WrapPersistent(resolver_.Get())));
}
UseCounter::Count(GetExecutionContext(), WebFeature::kWebNfcNdefReaderScan);
GetNfcProxy()->StartReading(
this, options,
WTF::Bind(&OnScanRequestCompleted, WrapPersistent(resolver_.Get())));
......
......@@ -14,6 +14,7 @@
#include "third_party/blink/renderer/modules/nfc/ndef_push_options.h"
#include "third_party/blink/renderer/modules/nfc/nfc_type_converters.h"
#include "third_party/blink/renderer/modules/nfc/nfc_utils.h"
#include "third_party/blink/renderer/platform/instrumentation/use_counter.h"
#include "third_party/blink/renderer/platform/weborigin/security_origin.h"
namespace blink {
......@@ -104,6 +105,8 @@ ScriptPromise NDEFWriter::push(ScriptState* script_state,
WrapPersistent(resolver)));
}
UseCounter::Count(execution_context, WebFeature::kWebNfcNdefWriterPush);
auto callback = WTF::Bind(&NDEFWriter::OnRequestCompleted,
WrapPersistent(this), WrapPersistent(resolver));
nfc_proxy_->Push(std::move(message),
......
......@@ -25513,6 +25513,8 @@ Called by update_net_error_codes.py.-->
<int value="3091" label="ResourceTimingTaintedOriginFlagFail"/>
<int value="3092" label="RegisterProtocolHandlerSameOriginAsTop"/>
<int value="3093" label="RegisterProtocolHandlerCrossOriginSubframe"/>
<int value="3094" label="WebNfcNdefReaderScan"/>
<int value="3095" label="WebNfcNdefWriterPush"/>
</enum>
<enum name="FeaturePolicyAllowlistType">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment