Commit b7e811c5 authored by yzshen's avatar yzshen Committed by Commit bot

Change the tracking request sent by NetErrorHelper from FrameTypeTopLevel to FrameTypeNone.

FrameTypeTopLevel in this case will be considered bad message by PlzNavigate.

This fixes browser tests with PlzNavigate:
ErrorPageTest.DNSError_DoClickLink
ErrorPageTest.DNSError_DoReload
ErrorPageTest.DNSError_DoReloadAfterSamePageNavigation
ErrorPageTest.DNSError_DoSearch
ErrorPageTest.StaleCacheStatus

BUG=576285

Review-Url: https://codereview.chromium.org/2285493002
Cr-Commit-Position: refs/heads/master@{#414660}
parent 952c4101
...@@ -297,7 +297,7 @@ void NetErrorHelper::SendTrackingRequest( ...@@ -297,7 +297,7 @@ void NetErrorHelper::SendTrackingRequest(
tracking_fetcher_->Start( tracking_fetcher_->Start(
render_frame()->GetWebFrame(), render_frame()->GetWebFrame(),
blink::WebURLRequest::RequestContextInternal, blink::WebURLRequest::RequestContextInternal,
blink::WebURLRequest::FrameTypeTopLevel, blink::WebURLRequest::FrameTypeNone,
content::ResourceFetcher::PLATFORM_LOADER, content::ResourceFetcher::PLATFORM_LOADER,
base::Bind(&NetErrorHelper::OnTrackingRequestComplete, base::Bind(&NetErrorHelper::OnTrackingRequestComplete,
base::Unretained(this))); base::Unretained(this)));
......
...@@ -83,9 +83,10 @@ ...@@ -83,9 +83,10 @@
-ErrorPageAutoReloadTest.IgnoresSamePageNavigation -ErrorPageAutoReloadTest.IgnoresSamePageNavigation
-ErrorPageAutoReloadTest.ManualReloadNotSuppressed -ErrorPageAutoReloadTest.ManualReloadNotSuppressed
-ErrorPageNavigationCorrectionsFailTest.FetchCorrectionsFails -ErrorPageNavigationCorrectionsFailTest.FetchCorrectionsFails
-ErrorPageTest.DNSError* -ErrorPageTest.DNSError_GoBack2
-ErrorPageTest.DNSError_GoBack2AndForward
-ErrorPageTest.DNSError_GoBack2Forward2
-ErrorPageTest.IFrameDNSError_JavaScript -ErrorPageTest.IFrameDNSError_JavaScript
-ErrorPageTest.StaleCacheStatus
-ExecuteScriptApiTest.ExecuteScriptByFrameId -ExecuteScriptApiTest.ExecuteScriptByFrameId
-ExecuteScriptApiTest.FrameWithHttp204 -ExecuteScriptApiTest.FrameWithHttp204
-ExecuteScriptApiTest/DestructiveScriptTest* -ExecuteScriptApiTest/DestructiveScriptTest*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment