cbuiv: remove IdleActionWarningDialogView Cancel override

This cancel override is essentially a no-op now. There is no cancel
button on this dialog so the only call path is via CloseDialog, which
always stops the timer before calling into Cancel, so Cancel was
always returning true. This change removes the Cancel override and
the explicit stop of the timer, which is no longer needed.

Bug: 1011446
Change-Id: Ifa6d42591ebcb4063aae05aa959199f407e50df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148678Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758962}

chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc

@@ -58,8 +58,7 @@ IdleActionWarningDialogView::IdleActionWarningDialogView(
 }
 
 void IdleActionWarningDialogView::CloseDialog() {
-  update_timer_.Stop();
-  CancelDialog();
+  GetWidget()->Close();
 }
 
 void IdleActionWarningDialogView::Update(base::TimeTicks idle_action_time) {
@@ -85,10 +84,6 @@ bool IdleActionWarningDialogView::ShouldShowCloseButton() const {
   return false;
 }
 
-bool IdleActionWarningDialogView::Cancel() {
-  return !update_timer_.IsRunning();
-}
-
 gfx::Size IdleActionWarningDialogView::CalculatePreferredSize() const {
   const int default_width = views::LayoutProvider::Get()->GetDistanceMetric(
       DISTANCE_MODAL_DIALOG_PREFERRED_WIDTH);
@@ -97,8 +92,7 @@ gfx::Size IdleActionWarningDialogView::CalculatePreferredSize() const {
       GetLayoutManager()->GetPreferredHeightForWidth(this, default_width));
 }
 
-IdleActionWarningDialogView::~IdleActionWarningDialogView() {
-}
+IdleActionWarningDialogView::~IdleActionWarningDialogView() = default;
 
 void IdleActionWarningDialogView::UpdateTitle() {
   GetWidget()->UpdateWindowTitle();

chrome/browser/chromeos/power/idle_action_warning_dialog_view.h

@@ -27,7 +27,6 @@ class IdleActionWarningDialogView : public views::DialogDelegateView {
   ui::ModalType GetModalType() const override;
   base::string16 GetWindowTitle() const override;
   bool ShouldShowCloseButton() const override;
-  bool Cancel() override;
 
   // views::View:
   gfx::Size CalculatePreferredSize() const override;