Commit b7f08dd0 authored by Gavin Williams's avatar Gavin Williams Committed by Chromium LUCI CQ

printing: Increase printer status logging

Increasing logging for better debugging of printer status request
failures.

Bug: 1027400
Change-Id: I262c7b4502a6527c187997239b16588591066bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643303Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarSean Kau <skau@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846448}
parent fcc6bc93
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
#include "chrome/browser/chromeos/printing/cups_printer_status_creator.h" #include "chrome/browser/chromeos/printing/cups_printer_status_creator.h"
#include "components/device_event_log/device_event_log.h"
namespace chromeos { namespace chromeos {
...@@ -17,6 +18,10 @@ CupsPrinterStatus PrinterStatusToCupsPrinterStatus( ...@@ -17,6 +18,10 @@ CupsPrinterStatus PrinterStatusToCupsPrinterStatus(
CupsPrinterStatus cups_printer_status(printer_id); CupsPrinterStatus cups_printer_status(printer_id);
for (const auto& reason : printer_status.reasons) { for (const auto& reason : printer_status.reasons) {
// TODO(crbug.com/1027400): Remove log once bug is confirmed fix.
PRINTER_LOG(DEBUG) << "Printer status received for printer " << printer_id
<< " reason: " << static_cast<int>(reason.reason)
<< " severity: " << static_cast<int>(reason.severity);
cups_printer_status.AddStatusReason( cups_printer_status.AddStatusReason(
PrinterReasonToCupsReason(reason.reason), PrinterReasonToCupsReason(reason.reason),
PrinterSeverityToCupsSeverity(reason.severity)); PrinterSeverityToCupsSeverity(reason.severity));
......
...@@ -96,6 +96,8 @@ export const ERROR_STRING_KEY_MAP = new Map([ ...@@ -96,6 +96,8 @@ export const ERROR_STRING_KEY_MAP = new Map([
*/ */
export function getStatusReasonFromPrinterStatus(printerStatus) { export function getStatusReasonFromPrinterStatus(printerStatus) {
if (!printerStatus.printerId) { if (!printerStatus.printerId) {
// TODO(crbug.com/1027400): Remove console log once bug is confirmed fix.
console.warn('Received printer status missing printer id');
return PrinterStatusReason.UNKNOWN_REASON; return PrinterStatusReason.UNKNOWN_REASON;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment