Commit b808a866 authored by Adrienne Walker's avatar Adrienne Walker Committed by Commit Bot

cc: Add diagnostic CHECKs to investigate crashes

There are some mysterious crashes in PlaybackFoldingIterator that I
suspect are coming from bogus PaintOpBuffers.

Bug: 823835
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabfa7d619a7dbb59e9b453d161e6dd7ca259795e
Reviewed-on: https://chromium-review.googlesource.com/974444Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544918}
parent 35a5c82f
...@@ -1236,6 +1236,8 @@ void DrawRecordOp::Raster(const DrawRecordOp* op, ...@@ -1236,6 +1236,8 @@ void DrawRecordOp::Raster(const DrawRecordOp* op,
SkCanvas* canvas, SkCanvas* canvas,
const PlaybackParams& params) { const PlaybackParams& params) {
// Don't use drawPicture here, as it adds an implicit clip. // Don't use drawPicture here, as it adds an implicit clip.
// TODO(enne): Temporary CHECK debugging for http://crbug.com/823835
CHECK(op->record);
op->record->Playback(canvas, params); op->record->Playback(canvas, params);
} }
......
...@@ -162,7 +162,8 @@ void RasterSource::PlaybackToCanvas( ...@@ -162,7 +162,8 @@ void RasterSource::PlaybackToCanvas(
void RasterSource::PlaybackToCanvas(SkCanvas* raster_canvas, void RasterSource::PlaybackToCanvas(SkCanvas* raster_canvas,
ImageProvider* image_provider) const { ImageProvider* image_provider) const {
DCHECK(display_list_.get()); // TODO(enne): Temporary CHECK debugging for http://crbug.com/823835
CHECK(display_list_.get());
int repeat_count = std::max(1, slow_down_raster_scale_factor_for_debug_); int repeat_count = std::max(1, slow_down_raster_scale_factor_for_debug_);
for (int i = 0; i < repeat_count; ++i) for (int i = 0; i < repeat_count; ++i)
display_list_->Raster(raster_canvas, image_provider); display_list_->Raster(raster_canvas, image_provider);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment