Commit b8289814 authored by timav's avatar timav Committed by Commit bot

Exclude text processing items for insertions and passwords

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090

Review-Url: https://codereview.chromium.org/2847793003
Cr-Commit-Position: refs/heads/master@{#467808}
parent fddf5df3
...@@ -455,6 +455,8 @@ public class SelectionPopupController extends ActionModeCallbackHelper { ...@@ -455,6 +455,8 @@ public class SelectionPopupController extends ActionModeCallbackHelper {
mActionMenuDescriptor = createActionMenuDescriptor(); mActionMenuDescriptor = createActionMenuDescriptor();
mActionMenuDescriptor.apply(menu); mActionMenuDescriptor.apply(menu);
if (isInsertion() || isSelectionPassword()) return;
initializeTextProcessingMenu(menu); initializeTextProcessingMenu(menu);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment