Commit b82f5fed authored by Andy Paicu's avatar Andy Paicu Committed by Commit Bot

Disabling HTTPSEarlyDataTest.TLSEarlyDataTest/TLSEarlyDataTooEarlyTest on iOS

First failing build: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/50593

TBR=mmenke@chromium.org

Bug: 1021021
Change-Id: Iaa80a2212610d407ed1062b50fb8309dd12dfcd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894010Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712097}
parent eee98ec9
...@@ -11176,8 +11176,15 @@ class HTTPSEarlyDataTest : public TestWithTaskEnvironment { ...@@ -11176,8 +11176,15 @@ class HTTPSEarlyDataTest : public TestWithTaskEnvironment {
EmbeddedTestServer test_server_; EmbeddedTestServer test_server_;
}; };
// Flaky on iOS, crbug.com/1021021
#if defined(OS_IOS)
#define MAYBE_TLSEarlyDataTest DISABLED_TLSEarlyDataTest
#else
#define MAYBE_TLSEarlyDataTest TLSEarlyDataTest
#endif
// TLSEarlyDataTest tests that we handle early data correctly. // TLSEarlyDataTest tests that we handle early data correctly.
TEST_F(HTTPSEarlyDataTest, TLSEarlyDataTest) { TEST_F(HTTPSEarlyDataTest, MAYBE_TLSEarlyDataTest) {
ASSERT_TRUE(test_server_.Start()); ASSERT_TRUE(test_server_.Start());
context_.http_transaction_factory()->GetSession()->ClearSSLSessionCache(); context_.http_transaction_factory()->GetSession()->ClearSSLSessionCache();
...@@ -11298,8 +11305,15 @@ std::unique_ptr<test_server::HttpResponse> HandleTooEarly( ...@@ -11298,8 +11305,15 @@ std::unique_ptr<test_server::HttpResponse> HandleTooEarly(
return std::make_unique<ZeroRTTResponse>(zero_rtt, true); return std::make_unique<ZeroRTTResponse>(zero_rtt, true);
} }
// Flaky on iOS, crbug.com/1021021
#if defined(OS_IOS)
#define MAYBE_TLSEarlyDataTooEarlyTest DISABLED_TLSEarlyDataTooEarlyTest
#else
#define MAYBE_TLSEarlyDataTooEarlyTest TLSEarlyDataTooEarlyTest
#endif
// Test that we handle 425 (Too Early) correctly. // Test that we handle 425 (Too Early) correctly.
TEST_F(HTTPSEarlyDataTest, TLSEarlyDataTooEarlyTest) { TEST_F(HTTPSEarlyDataTest, MAYBE_TLSEarlyDataTooEarlyTest) {
bool sent_425 = false; bool sent_425 = false;
test_server_.RegisterRequestHandler( test_server_.RegisterRequestHandler(
base::BindRepeating(&HandleTooEarly, base::Unretained(&sent_425))); base::BindRepeating(&HandleTooEarly, base::Unretained(&sent_425)));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment