Commit b85fc6de authored by miu's avatar miu Committed by Commit bot

[Cocoa] Crash fix, caused by recent tab indicator change.

I misunderstood how ObjectiveC handled pointers declared with __weak.
This change resolves the issue by nil'ing things out in
[TabController dealloc], the standard solution.

Introduced by: https://codereview.chromium.org/688523002/

BUG=429605

Review URL: https://codereview.chromium.org/699013002

Cr-Commit-Position: refs/heads/master@{#302536}
parent a1ca66cf
...@@ -128,6 +128,8 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate { ...@@ -128,6 +128,8 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {
} }
- (void)dealloc { - (void)dealloc {
[mediaIndicatorButton_ setAnimationDoneTarget:nil withAction:nil];
[mediaIndicatorButton_ setClickTarget:nil withAction:nil];
[[NSNotificationCenter defaultCenter] removeObserver:self]; [[NSNotificationCenter defaultCenter] removeObserver:self];
[[self tabView] setController:nil]; [[self tabView] setController:nil];
[super dealloc]; [super dealloc];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment